From 750f0f6b0296057ff9910cebd2ac2f577b0cdb90 Mon Sep 17 00:00:00 2001 From: Antti Date: Mon, 27 Mar 2023 21:41:53 +0800 Subject: [PATCH 1/2] fix: Ensure additional_thumbprint validation allows a null value (#26) Thanks to @officel for input Co-authored-by: NISHIMURA Yoshitaka --- variables.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/variables.tf b/variables.tf index 2cfb28f..ed42eb4 100644 --- a/variables.tf +++ b/variables.tf @@ -18,7 +18,7 @@ variable "additional_thumbprints" { type = list(string) validation { - condition = length(var.additional_thumbprints) <= 4 + condition = var.additional_thumbprints == null ? true : length(var.additional_thumbprints) <= 4 error_message = "Only 4 additional thumbprints can be set, for a maximum of 5 in the OIDC provider." } } From f70be51762e4072d974a263ebfe6f1aa092c004d Mon Sep 17 00:00:00 2001 From: Daniel Morris Date: Mon, 27 Mar 2023 14:44:56 +0100 Subject: [PATCH 2/2] Prepare release v1.3.1 --- CHANGELOG.md | 5 +++++ README.md | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b18620d..8adce1a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,10 @@ Notable changes to this project are documented in this changelog. This project adheres to the [semantic versioning] specification. +## [1.3.1] – 2023-03-27 + +- Ensure the additional_thumbprints variable allows null values ([750f0f6](https://github.com/unfunco/terraform-aws-oidc-github/commit/750f0f6b0296057ff9910cebd2ac2f577b0cdb90)) + ## [1.3.0] – 2023-03-21 - Added a variable to allow additional thumbprints to be specified ([f3ca314](https://github.com/unfunco/terraform-aws-oidc-github/commit/f3ca3143052eecf59fc08be8dbb288855764414f)) @@ -101,4 +105,5 @@ This project adheres to the [semantic versioning] specification. [1.2.0]: https://github.com/unfunco/terraform-aws-oidc-github/compare/v1.1.1...v1.2.0 [1.2.1]: https://github.com/unfunco/terraform-aws-oidc-github/compare/v1.2.0...v1.2.1 [1.3.0]: https://github.com/unfunco/terraform-aws-oidc-github/compare/v1.2.1...v1.3.0 +[1.3.1]: https://github.com/unfunco/terraform-aws-oidc-github/compare/v1.3.0...v1.3.1 [semantic versioning]: https://semver.org diff --git a/README.md b/README.md index 3a22177..393f50e 100644 --- a/README.md +++ b/README.md @@ -28,7 +28,7 @@ provider "aws" { module "oidc_github" { source = "unfunco/oidc-github/aws" - version = "1.3.0" + version = "1.3.1" github_repositories = [ "org/repo",