Alternative for releaseable? that doesn't always evaluate to true.#2
Open
EvenMoreIrrelevance wants to merge 2 commits intouncomplicate:masteruncomplicate/commons:masterfrom
EvenMoreIrrelevance:masterEvenMoreIrrelevance/uncomplicate-commons:masterCopy head branch name to clipboard
Open
Alternative for releaseable? that doesn't always evaluate to true.#2EvenMoreIrrelevance wants to merge 2 commits intouncomplicate:masteruncomplicate/commons:masterfrom EvenMoreIrrelevance:masterEvenMoreIrrelevance/uncomplicate-commons:masterCopy head branch name to clipboard
releaseable? that doesn't always evaluate to true.#2EvenMoreIrrelevance wants to merge 2 commits intouncomplicate:masteruncomplicate/commons:masterfrom
EvenMoreIrrelevance:masterEvenMoreIrrelevance/uncomplicate-commons:masterCopy head branch name to clipboard
Conversation
Member
|
I won't be able to look at this in the next couple of weeks, but will look at it and consider it after that. Thanks for being patient. Can you please see how it's used in other uncomplicate code? Maybe releasable can be re-defined to match your intentions with nontrivially-releaseable? |
Author
|
Searching for |
Member
|
Then I guess it's a vestige of some long-gone code... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to how
satisfies?works and due toObjectandnilimplementations being defined forRelease,release?effectively is a clone ofany?under any sensible circumstances.Simply altering
releaseable?is a breaking change, so this pull request introduces anontrivially-releaseable?fn which checks if the object isn'tniland if its implementation is different fromObject's and a note about it inrelease?'s docs.