Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[CI] fix tests and change iOS CI/CD#13

Merged
alexvbush merged 1 commit intouber:mainuber/RIBs-iOS:mainfrom
rbrovko:developrbrovko/RIBs-iOS:developCopy head branch name to clipboard
May 1, 2025
Merged

[CI] fix tests and change iOS CI/CD#13
alexvbush merged 1 commit intouber:mainuber/RIBs-iOS:mainfrom
rbrovko:developrbrovko/RIBs-iOS:developCopy head branch name to clipboard

Conversation

@rbrovko
Copy link
Copy Markdown
Contributor

@rbrovko rbrovko commented Apr 29, 2025

This PR fixes unit-testing compilation issue described in #10 and #9

Setup iOS CI/CD with run tests with coverage and lint podspec

@alexvbush
Copy link
Copy Markdown
Collaborator

alexvbush commented Apr 30, 2025

@rbrovko thank you for your submission! We are still considering cocoapods support but likely won't have it be used for the CI/CD.

Could you rebase with the main branch and resubmit just the podspec setup fixes?

@rbrovko
Copy link
Copy Markdown
Contributor Author

rbrovko commented Apr 30, 2025

@alexvbush done.
Maybe better use merge with squash commits.

Coverage         
----------------------------------------------------------------------------------------------------------------- ---------------- 
RIBs.framework                                                                                                    54.93% (451/821) 

from https://github.com/rbrovko/RIBs-iOS/actions/runs/14747215729/job/41396745098

@alexvbush
Copy link
Copy Markdown
Collaborator

thank you @rbrovko !

@alexvbush alexvbush merged commit 40997fb into uber:main May 1, 2025
2 checks passed
@alexvbush
Copy link
Copy Markdown
Collaborator

this closes #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.