Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Deprecate js override bits #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2022
Merged

Conversation

masklinn
Copy link
Contributor

@masklinn masklinn commented May 5, 2022

They were a feature for testing whose need was removed in 2015 (ua-parser/uap-core#58). They are entirely unnecessary, it is possible a user somewhere is leveraging them for some reason.

So remove the override bits from the docstrings, and have them trigger a DeprecationWarning.

Also:

  • add tests that they do trigger
  • remove support for them from the yaml testing functions
  • update the pytest invocations to raise on all warnings
  • while at it remove the apparently dead makePGTSComparisonYAML test utility method (?)
  • and add pypy to the envlist

@masklinn masklinn force-pushed the deprecated-js-bits branch 2 times, most recently from 0d7f59b to 7735f9a Compare May 5, 2022 13:46
They were a feature for testing whose need was removed in
2015 (ua-parser/uap-core#58). They are *entirely* unnecessary, it is
possible a user somewhere is leveraging them for some reason.

So remove the override bits from the docstrings, and have them trigger
a `DeprecationWarning`.

Also:

- add tests that they do trigger
- remove support for them from the yaml testing functions
- update the pytest invocations to raise on all warnings
- while at it remove the apparently dead makePGTSComparisonYAML test
  utility method (?)
- and add pypy to the envlist

Note: `simplefilter` has to be updated to `"always"` for 2.7's dumb
      ass: the new tests triggers the same warning multiple times and
      of course `"default"` only yields them once.

final
@masklinn masklinn force-pushed the deprecated-js-bits branch from 5bf7599 to 71eb922 Compare May 5, 2022 14:02
@masklinn masklinn merged commit c300922 into ua-parser:master May 5, 2022
@masklinn masklinn deleted the deprecated-js-bits branch May 5, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
Morty Proxy This is a proxified and sanitized view of the page, visit original site.