Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

_lookup() generates KeyError exception #132

Copy link
Copy link
Closed
@michael-a-green

Description

@michael-a-green
Issue body actions

Method user_agent_parser::_lookup() generates a KeyError exception at line 237 in uap-python/ua_parser/user_agent_parser.py. Not all callers of this method can handle the exception.

It would be better if line 237 was this:

_PARSE_CACHE.pop(next(iter(_PARSE_CACHE)), "UNKNOWN")

I'll send a pull request. Please let me know if you need more info.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.