Specify which CSL style is not suitable for bibliographies #6306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurmaedje
reviewed
Jun 4, 2025
| .ok_or("CSL style is not suitable for bibliographies") | ||
| .ok_or_else(|| { | ||
| eco_format!( | ||
| "{:?} CSL style is not suitable for bibliographies", |
There was a problem hiding this comment.
Using {:?} debug formatting here is problematic as it fill use Rust-style formatting (e.g. Bytes(10)). I think we should instead only print a name if we know it (i.e. for named styles via style.names()). I would also reorder this, so that the final message is
eco_format!("CSL style `{}` is not suitable for bibliographies", name.repr())If there is no name, we can keep the old message.
Could you also add tests for both cases?
There was a problem hiding this comment.
Where does .repr() come from?
no method named `repr` found for enum `hayagriva::archive::ArchivedStyle` in the current scope items from traits can only be used if the trait is implemented and in scope [E0599]
I don't know where does .names() gets multiple names if we can only specify one. There is also .display_name(). Why not use it?
I also don't know how to add test for this because of unnamed variant and because of plurality. Is it a pure Typst or Rust test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While stumbling into
"alphanumeric"style for the nth time, I found that now apparently it errors that you can't use it for bibliography (it appears that I need to exclusively use it withcite()). But the error is vague, IMO.Which style? It would be helpful to see more info. Initially I thought that this is better:
But then I switched to
And finally ended up with
This works for named styles and file paths. Though as always, I don't know what is the most efficient way to get X (string name) from Y (style field type), but it looks short enough.
Perhaps a hint can be added to point out other built-in styles that will work.
P.S. I in fact still haven't read the latest changelog...