Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat: support TypeScript 5.5 #9397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 22, 2024
Merged

feat: support TypeScript 5.5 #9397

merged 6 commits into from
Jun 22, 2024

Conversation

bradzacher
Copy link
Member

PR Checklist

Overview

Pretty straightforward. No changes impacted us aside from API deprecations.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@bradzacher bradzacher requested a review from a team June 21, 2024 06:14
Copy link

netlify bot commented Jun 21, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit bad276f
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6676232bcadc340008a32f5c
😎 Deploy Preview https://deploy-preview-9397--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Jun 21, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bad276f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

South Park's Eric Cartman saying "SWEET"

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jun 21, 2024
kirkwaiblinger
kirkwaiblinger previously approved these changes Jun 21, 2024
Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

return String.fromCodePoint(
...chars.map(c => (c as RegExpAST.Character).value),
);
return String.fromCodePoint(...chars.map(c => c.value));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swell

@bradzacher bradzacher merged commit dc18229 into main Jun 22, 2024
63 checks passed
@bradzacher bradzacher deleted the ts5_5 branch June 22, 2024 01:26
cm-ayf added a commit to cm-ayf/typescript-eslint that referenced this pull request Jun 22, 2024
const SUPPORTED_TYPESCRIPT_VERSIONS needs to be kept in sync with package.json in the typescript-eslint monorepo. However, this was not changed in typescript-eslint#9397.
@RobinTail
Copy link
Contributor

RobinTail commented Jun 24, 2024

@JoshuaKGoldberg , could you please also add this feature into v8, the version that supports ESLint 9, please?

@bradzacher
Copy link
Member Author

bradzacher commented Jun 24, 2024

We will merge main into v8 when we have the opportunity. Please be patient. Tagging maintainers does not increase priority and just creates notification spam.

@typescript-eslint typescript-eslint locked and limited conversation to collaborators Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript 5.5 Support
4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.