From ce8d2965625865f7ad3880a06ab402818ad47240 Mon Sep 17 00:00:00 2001 From: Pete Gonzalez <4673363+octogonz@users.noreply.github.com> Date: Mon, 15 Jan 2024 17:56:37 -0800 Subject: [PATCH 1/3] fix(rule-tester): Fix a phantom dependency on the "semver" package in DependencyConstraint.d.ts --- packages/rule-tester/src/types/DependencyConstraint.ts | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/packages/rule-tester/src/types/DependencyConstraint.ts b/packages/rule-tester/src/types/DependencyConstraint.ts index a59a0a737061..fbc31fcbb969 100644 --- a/packages/rule-tester/src/types/DependencyConstraint.ts +++ b/packages/rule-tester/src/types/DependencyConstraint.ts @@ -1,4 +1,11 @@ -import type { RangeOptions } from 'semver'; +// `Options` and `RangeOptions` are defined in the 'semver' package. +// We redeclare them here to avoid a peer dependency on that package: +export interface Options { + loose?: boolean | undefined; +} +export interface RangeOptions extends Options { + includePrerelease?: boolean | undefined; +} export interface SemverVersionConstraint { readonly range: string; From bdb40eaf7c332842d2a63bb57cc1aa56bdca4a3c Mon Sep 17 00:00:00 2001 From: Pete Gonzalez <4673363+octogonz@users.noreply.github.com> Date: Thu, 1 Feb 2024 11:25:07 -0800 Subject: [PATCH 2/3] Update packages/rule-tester/src/types/DependencyConstraint.ts MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Josh Goldberg ✨ --- packages/rule-tester/src/types/DependencyConstraint.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/rule-tester/src/types/DependencyConstraint.ts b/packages/rule-tester/src/types/DependencyConstraint.ts index fbc31fcbb969..f067b05505f3 100644 --- a/packages/rule-tester/src/types/DependencyConstraint.ts +++ b/packages/rule-tester/src/types/DependencyConstraint.ts @@ -1,10 +1,8 @@ // `Options` and `RangeOptions` are defined in the 'semver' package. // We redeclare them here to avoid a peer dependency on that package: -export interface Options { - loose?: boolean | undefined; -} export interface RangeOptions extends Options { includePrerelease?: boolean | undefined; + loose?: boolean | undefined; } export interface SemverVersionConstraint { From 5d5c61b59e7c2577a30b17994f90bf1ad4498d61 Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Sat, 3 Feb 2024 17:03:04 -0500 Subject: [PATCH 3/3] Remove 'extends Options' --- packages/rule-tester/src/types/DependencyConstraint.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/rule-tester/src/types/DependencyConstraint.ts b/packages/rule-tester/src/types/DependencyConstraint.ts index f067b05505f3..f2b38dbf2245 100644 --- a/packages/rule-tester/src/types/DependencyConstraint.ts +++ b/packages/rule-tester/src/types/DependencyConstraint.ts @@ -1,6 +1,6 @@ // `Options` and `RangeOptions` are defined in the 'semver' package. // We redeclare them here to avoid a peer dependency on that package: -export interface RangeOptions extends Options { +export interface RangeOptions { includePrerelease?: boolean | undefined; loose?: boolean | undefined; }