Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

chore: enable jsdoc/informative-docs internally #8157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Sending as a draft for reference in triage.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Dec 29, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 4d0d334
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65e71d328472f00008567c7f
😎 Deploy Preview https://deploy-preview-8157--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 9 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review February 4, 2024 15:52
Copy link

nx-cloud bot commented Feb 4, 2024

@JoshuaKGoldberg JoshuaKGoldberg added the blocked by another PR PRs which are ready to go but waiting on another PR label Feb 10, 2024
@JoshuaKGoldberg
Copy link
Member Author

JoshuaKGoldberg commented Feb 10, 2024

I'll wait to continue -let alone merge- these changes until the flat config work lands.

Edit: ✔️

@JoshuaKGoldberg JoshuaKGoldberg removed the blocked by another PR PRs which are ready to go but waiting on another PR label Feb 21, 2024
bradzacher
bradzacher previously approved these changes Feb 22, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit aeb2f71 into typescript-eslint:main Mar 5, 2024
@JoshuaKGoldberg JoshuaKGoldberg deleted the jsdoc-informative-docs branch March 5, 2024 14:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo: Bring in eslint-plugin-jsdoc informative-docs rule
3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.