test(ast-spec): snapshot codeframe of error #6555
Conversation
☁️ Nx Cloud ReportWe didn't find any information for the current pull request with the commit 33a4fec. Check the Nx Cloud Github Integration documentation for more information. Sent with 💌 from NxCloud. |
|
Thanks for the PR, @fisker! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
this is a great idea!
I wonder if we should be capturing an end as well as part of the TSError?
That way we could throw errors on ranges instead of just on single characters.
Looks like code-frame also supports an end range, so we would even be able to snapshot it.
WDYT?
Prettier throws errors include a start and an end, see this diff. |
|
@bradzacher Don't know how to fix this, can you help? |
|
oops - i didn't see the error before merging 🤦 |
|
Should be fixed by f98afd2 |
PR Checklist
Overview
During upgrade parser to v6 in Prettier, I found some error location should be improved, but before that, let's make the error visible?