fix(eslint-plugin): extend base config using plugin syntax relative path #1593
Conversation
- [ ] extends prevent shimming for yarn v2 compatibility
|
Thanks for the PR, @AlexandreBonaventure! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
|
The fact that yarn v2 is breaking the relative path resolution ESLint relies on seems like a bug on yarn's end. So to me this seems like something that should be fixed in yarn v2. I'm strongly in favour of the former, as it seems like yarn v2 is breaking some guarantee that existing libraries depend on. |
|
@AlexandreBonaventure - are you seeing errors similar to the one listed in #1592? |
|
Having a quick look at your profile, I see you've opened a PR in another eslint config package as well (vuejs/eslint-config-typescript#8). This is an immediate red flag for me. This is an existing workflow which is being broken by yarn v2. |
|
@bradzacher you are right, opening those PRs was a way for me to find some solutions. I've just pushed a new commit to the eslint-config-typescript that should make things work without doing any changes here. So closing... |
Trying to make vue eslint typescript config compatible with yarn v2, I hit several blockers, one being extends with relative path prevent shimming.
This aims to make Yarn v2 compat less painful, but I'm not claiming I have the truth, this is a open discussion on how we can make it work together, thanks.