Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix(eslint-plugin): extend base config using plugin syntax relative path #1593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AlexandreBonaventure
Copy link

Trying to make vue eslint typescript config compatible with yarn v2, I hit several blockers, one being extends with relative path prevent shimming.
This aims to make Yarn v2 compat less painful, but I'm not claiming I have the truth, this is a open discussion on how we can make it work together, thanks.

- [ ] extends prevent shimming for yarn v2 compatibility
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @AlexandreBonaventure!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@armano2 armano2 requested review from JamesHenry and bradzacher and removed request for JamesHenry and bradzacher February 11, 2020 20:29
@armano2 armano2 added DO NOT MERGE PRs which should not be merged yet enhancement New feature or request package: typescript-estree Issues related to @typescript-eslint/typescript-estree and removed package: typescript-estree Issues related to @typescript-eslint/typescript-estree labels Feb 11, 2020
@bradzacher
Copy link
Member

The fact that yarn v2 is breaking the relative path resolution ESLint relies on seems like a bug on yarn's end.

So to me this seems like something that should be fixed in yarn v2.
Or alternately, ESLint should add support for yarn v2.

I'm strongly in favour of the former, as it seems like yarn v2 is breaking some guarantee that existing libraries depend on.

@bradzacher
Copy link
Member

@AlexandreBonaventure - are you seeing errors similar to the one listed in #1592?

@bradzacher
Copy link
Member

Having a quick look at your profile, I see you've opened a PR in another eslint config package as well (vuejs/eslint-config-typescript#8).

This is an immediate red flag for me. This is an existing workflow which is being broken by yarn v2.

@AlexandreBonaventure
Copy link
Author

@bradzacher you are right, opening those PRs was a way for me to find some solutions. I've just pushed a new commit to the eslint-config-typescript that should make things work without doing any changes here. So closing...
thanks

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DO NOT MERGE PRs which should not be merged yet enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.