refactor(ts-estree): add types to converter #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
==========================================
- Coverage 95.82% 95.68% -0.15%
==========================================
Files 51 51
Lines 2541 2458 -83
Branches 373 372 -1
==========================================
- Hits 2435 2352 -83
- Misses 63 65 +2
+ Partials 43 41 -2
|
|
we should really raise a separate PR to remove all of the JSDoc types from the codebase... |
|
both PR adds same file (ast structure), and they are not blocking each other. On spectrum i was referring to different change :) |
|
@bradzacher @JamesHenry i aligned types ( |
This was referenced Feb 3, 2019
JamesHenry
requested changes
Feb 3, 2019
|
I manually ran some real-world "benchmarks" by building from this PR and including it in a build of Prettier and running it on a real codebase (angular.io documentation website) and can confirm there are not any performance regressions/issues |
JamesHenry
approved these changes
Feb 3, 2019
|
Thanks for all the work on this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is prototype of converter with types, with small improvement to performance (this is not goal of this PR).
Changes:
temp-types-based-on-js-source.tstoparser-options.ts...
before
Complex File:
ts-estree x 238 ops/sec ±2.14% (86 runs sampled)Simple File:
ts-estree x 10,706 ops/sec ±3.19% (87 runs sampled)after
Complex File:
ts-estree x 262 ops/sec ±1.78% (84 runs sampled)Simple File:
ts-estree x 11,049 ops/sec ±3.26% (80 runs sampled)