Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

docs: update supported parser options #11012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

docs: update supported parser options #11012

wants to merge 1 commit into from

Conversation

snitin315
Copy link

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @snitin315!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Mar 31, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 4f42767
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67ea53f281325100084d2adc
😎 Deploy Preview https://deploy-preview-11012--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 31, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 4f42767.

Command Status Duration Result
nx run-many --target=build --exclude website --... ✅ Succeeded 2s View ↗
nx run-many --target=clean ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-31 08:45:14 UTC

@bradzacher
Copy link
Member

as per our contirbuting guide -- please don't file PRs without first filing an issue.

@bradzacher bradzacher closed this Mar 31, 2025
@JoshuaKGoldberg
Copy link
Member

Ah, just found the context: eslint/eslint#19563 (comment)

Not all of these properties are allowed to be set in user configs. At least:

typescript-eslint/packages/parser/src/parser.ts

Lines 120 to 133 in a885343

const tsestreeOptions = {
jsx: validateBoolean(parserOptions.ecmaFeatures.jsx),
...(!warnOnUnsupportedTypeScriptVersion && { loggerFn: false }),
...parserOptions,
// Override errorOnTypeScriptSyntacticAndSemanticIssues and set it to false to prevent use from user config
// https://github.com/typescript-eslint/typescript-eslint/issues/8681#issuecomment-2000411834
errorOnTypeScriptSyntacticAndSemanticIssues: false,
// comment, loc, range, and tokens should always be set for ESLint usage
// https://github.com/typescript-eslint/typescript-eslint/issues/8347
comment: true,
loc: true,
range: true,
tokens: true,
} satisfies TSESTreeOptions;

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Mar 31, 2025
Open
2 tasks
@JoshuaKGoldberg
Copy link
Member

Filed: #11016

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snitin315 @bradzacher @JoshuaKGoldberg
Morty Proxy This is a proxified and sanitized view of the page, visit original site.