Repo: reuse newly added "is builtin symbol like" logic from type-utils

Suggestion

We've added few utility functions to the packages/type-utils/src/builtinSymbolLikes.ts

Basically they contain the logic for determining whether a given type is a type from the TS default library or not

These files already contain similar logic, it'd be cool if we dedupe it!

typescript-eslint/packages/eslint-plugin/src/rules/no-implied-eval.ts

Lines 82 to 90 in 705370a

    
           if (symbol && symbol.escapedName === FUNCTION_CONSTRUCTOR) { 
        
             const declarations = symbol.getDeclarations() ?? []; 
        
             for (const declaration of declarations) { 
        
               const sourceFile = declaration.getSourceFile(); 
        
               if (services.program.isSourceFileDefaultLibrary(sourceFile)) { 
        
                 return true; 
        
               } 
        
             } 
        
           }

typescript-eslint/packages/eslint-plugin/src/rules/no-implied-eval.ts

Lines 145 to 153 in 705370a

    
           if (symbol) { 
        
             const declarations = symbol.getDeclarations() ?? []; 
        
             for (const declaration of declarations) { 
        
               const sourceFile = declaration.getSourceFile(); 
        
               if (services.program.isSourceFileDefaultLibrary(sourceFile)) { 
        
                 context.report({ node, messageId: 'noFunctionConstructor' }); 
        
                 return; 
        
               } 
        
             }

Let's label this issue as good first issue? Ref: #8011 (comment)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Repo: reuse newly added "is builtin symbol like" logic from `type-utils` #8234

Suggestion

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (symbol && symbol.escapedName === FUNCTION_CONSTRUCTOR) {
	const declarations = symbol.getDeclarations() ?? [];
	for (const declaration of declarations) {
	const sourceFile = declaration.getSourceFile();
	if (services.program.isSourceFileDefaultLibrary(sourceFile)) {
	return true;
	}
	}
	}

	if (symbol) {
	const declarations = symbol.getDeclarations() ?? [];
	for (const declaration of declarations) {
	const sourceFile = declaration.getSourceFile();
	if (services.program.isSourceFileDefaultLibrary(sourceFile)) {
	context.report({ node, messageId: 'noFunctionConstructor' });
	return;
	}
	}

Search code, repositories, users, issues, pull requests...

Uh oh!

Repo: reuse newly added "is builtin symbol like" logic from type-utils #8234

Description

Suggestion

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Repo: reuse newly added "is builtin symbol like" logic from `type-utils` #8234