Closed as not planned
Description
Suggestion
In #7914 I added wrapper methods so we can support multiple versions of ESLint, per https://eslint.org/blog/2023/09/preparing-custom-rules-eslint-v9/ -> #7816 -> #7812.
- context.getSourceCode()
+ getSourceCode(context)
The wrapper methods mean our rules will work on ESLint 7, 8, and even 9 once the old deprecated versions are removed. We should lint to make sure folks are using the wrappers and not the new, doesn't-exist-in-old-ESLint versions equivalents.
Unit tests will eventually capture this too but I think failing a lint rule -especially if it has an auto-fixer- would be much easier for contributors.
Aside: I did that PR without any review to quickly fix lint failures on the main
branch. If there's some better way to approach this problem, we should consider it!
Metadata
Metadata
Assignees
Labels
things to do with maintenance of the repo, and not with code/docsthings to do with maintenance of the repo, and not with code/docsWaiting for team members to take a lookWaiting for team members to take a look