Closed
Description
Before You File a Proposal Please Confirm You Have Done The Following...
- I have searched for related issues and found none that match my proposal.
- I have searched the current rule list and found no rules that match my proposal.
- I have read the FAQ and my problem is not listed.
My proposal is suitable for this project
- I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).
Link to the rule's documentation
https://typescript-eslint.io/rules/no-floating-promises/
Description
When moving to TS/upgrading legacy code you often have e.g. jQuery.ajax() calls which now return a promise, but 99% of people write their success/error callbacks directly in the param object.
This leads to tons of eslint-disable-next-line comments.
An option for the rule like ignorePattern
(which exists in eslint for various rules) which would exclude certain patterns from reporting an error would be great
Fail
no change
Pass
jQuery.ajax({
method: 'POST',
url: 'example.com',
data: {
foo: 'bar',
},
complete: function() {
doSomething();
}
});
Additional Info
No response
Metadata
Metadata
Assignees
Labels
This issue or pull request already existsThis issue or pull request already existsNew rule option for an existing eslint-plugin ruleNew rule option for an existing eslint-plugin ruleIssues related to @typescript-eslint/eslint-pluginIssues related to @typescript-eslint/eslint-plugin