Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Enhancement: [no-floating-promises] add ignorePattern #7006

Copy link
Copy link
Closed
@kkmuffme

Description

@kkmuffme
Issue body actions

Before You File a Proposal Please Confirm You Have Done The Following...

My proposal is suitable for this project

  • I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Link to the rule's documentation

https://typescript-eslint.io/rules/no-floating-promises/

Description

When moving to TS/upgrading legacy code you often have e.g. jQuery.ajax() calls which now return a promise, but 99% of people write their success/error callbacks directly in the param object.

This leads to tons of eslint-disable-next-line comments.

An option for the rule like ignorePattern (which exists in eslint for various rules) which would exclude certain patterns from reporting an error would be great

Fail

no change

Pass

jQuery.ajax({
	method: 'POST',
	url: 'example.com',
	data: {
		foo: 'bar',
	},
	complete: function() {
		doSomething();
	}
});

Additional Info

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    duplicateThis issue or pull request already existsThis issue or pull request already existsenhancement: plugin rule optionNew rule option for an existing eslint-plugin ruleNew rule option for an existing eslint-plugin rulepackage: eslint-pluginIssues related to @typescript-eslint/eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.