Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Enhancement: Add test-only console warnings to deprecated AST properties  #6469

Copy link
Copy link
Closed
@JoshuaKGoldberg

Description

@JoshuaKGoldberg
Issue body actions

Before You File a Proposal Please Confirm You Have Done The Following...

Relevant Package

typescript-estree

My proposal is suitable for this project

  • I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Description

From @bradzacher's suggestion in #5384 (comment), which renamed many properties from typeParameters to typeArguments:

Thinking about this in terms of the broader ecosystem and the impacts - I wonder if we want to give consumers one major version to migrate? A hard cut over might be a bit difficult for the ecosystem to come handle as it would involve every single plugin updating their code (which could leave users in an impossible to upgrade state for some time).

How about this: this version we add the new property and we mark the old property as @deprecated, then in v7 we remove the old property entirely.

If we wanted we could also do something like define a getter that throws when in a test environment to help flag plugins that they should migrate.

#5384 kept the old properties as @deprecated but didn't add a getter.

Additional Info

No response

Metadata

Metadata

Labels

accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issueenhancementNew feature or requestNew feature or request

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.