Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Rule rename: no-extraneous-class -> no-class-as-namespace #6035

Copy link
Copy link
Closed
@JoshuaKGoldberg

Description

@JoshuaKGoldberg
Issue body actions

Overview

Porting context from #6022 > #6022 (comment):

A number of the no- rules make sense as things that won't be turned on and have no inverse, so a blanket rule against no- prefixes is a bad idea.
I agree though that it makes sense for us to advise against that naming if it's feasible that we will add inverse functionality to a rule.

@typescript-eslint/no-extraneous-class is mentioned as a potential rule to rename:

  • I doubt anyone would ever want the inverse of this unless they absolutely love java.
  • would be good to rename this so it's clearer though (no-class-as-namespace?)

Personally, I slightly prefer no-extraneous-class because it directly implies that the practice is bad. no-class-as-namespace just says what the practice is, without that explicit negative connotation. But maybe that's just me - posting this issue to hear other folks' thoughts!

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestNew feature or requestpackage: eslint-pluginIssues related to @typescript-eslint/eslint-pluginIssues related to @typescript-eslint/eslint-plugintriageWaiting for team members to take a lookWaiting for team members to take a look

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.