Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat(typescript-estree): forbid computed EnumMember #11232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
Loading
from
Open

feat(typescript-estree): forbid computed EnumMember #11232

wants to merge 9 commits into from
+101 −231

Conversation

fisker
Copy link
Contributor

@fisker fisker commented May 21, 2025

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented May 21, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit f60ffa6
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/682e27c4373c8f0008fd9864
😎 Deploy Preview https://deploy-preview-11232--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 21, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit f60ffa6.

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m View ↗
nx run-many -t typecheck ✅ Succeeded 2m 10s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 18s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 7s View ↗
nx run types:build ✅ Succeeded <1s View ↗
nx run-many -t lint ✅ Succeeded 8s View ↗
nx typecheck ast-spec ✅ Succeeded <1s View ↗
nx run integration-tests:test ✅ Succeeded <1s View ↗
Additional runs (29) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-05-21 19:35:50 UTC

@fisker fisker force-pushed the non-computed-enum-member branch from 45c92cb to 82e8533 Compare May 21, 2025 17:18
@fisker fisker marked this pull request as draft May 21, 2025 17:31
@fisker fisker mentioned this pull request May 21, 2025
Open
4 tasks
fisker
fisker commented May 21, 2025
View reviewed changes
packages/eslint-plugin/src/rules/naming-convention.ts
Comment on lines +636 to +637
// Unknown reason, can't get the correct type
const id = node.id as TSESTree.Identifier | TSESTree.StringLiteral;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the build script is using the published package instead of local one. I tried to use workspace:^, but still can't build.

@codecov Codecov
Copy link

codecov bot commented May 21, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 13 lines in your changes missing coverage. Please review.

Project coverage is 90.88%. Comparing base (4ad8a07) to head (f60ffa6).

Files with missing lines Patch % Lines
packages/typescript-estree/src/convert.ts 62.85% 13 Missing ⚠️

❌ Your patch check has failed because the patch coverage (66.66%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11232      +/-   ##
==========================================
- Coverage   90.91%   90.88%   -0.03%     
==========================================
  Files         501      501              
  Lines       50869    50887      +18     
  Branches     8382     8380       -2     
==========================================
+ Hits        46248    46250       +2     
- Misses       4606     4622      +16     
  Partials       15       15
Flag Coverage Δ
unittest 90.88% <66.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...kages/eslint-plugin/src/rules/naming-convention.ts 97.79% <100.00%> (-0.02%) ⬇️
...ackages/scope-manager/src/referencer/Referencer.ts 97.93% <100.00%> (-0.01%) ⬇️
packages/typescript-estree/src/convert.ts 30.81% <62.85%> (+0.15%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fisker fisker marked this pull request as ready for review May 21, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fisker
Morty Proxy This is a proxified and sanitized view of the page, visit original site.