Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Bug: Parser: End range of Program differs from Espree #11026

Copy link
Copy link
Open
@overlookmotel

Description

@overlookmotel
Issue body actions

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Relevant Package

parser

Playground Link

https://typescript-eslint.io/play/#ts=5.7.2&showAST=es&fileType=.tsx&code=PTAEDMHtIKBgPOJQCMCGAnGQ&eslintrc=N4KABGBEBOCuA2BTAzpAXGYBfEWg&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

Repro Code

// foo

x

// bar

ESLint Config

tsconfig

Expected Result

The end location of Program differs between @typescript-eslint/parser and Espree.

Both TS-ESLint and Espree set the start location of Program as the first token, excluding whitespace and comments.

Espree sets the end location as the last token, also excluding whitespace and comments. However, @typescript-eslint/parser does not match that behavior - end location of Program is the end of the file.

I assume that @typescript-eslint/parser is aiming to align with Espree, and therefore this difference is unintentional.

Acorn does not exclude whitespace/comments from either start or end location. It's unfortunate the the 2 most-used ESTree-compatible parsers do not match each others' behavior, and personally I prefer the Acorn way - I think it's surprising that you can have comments which have locations outside the Program which contains them. But I imagine quite possible that neither Acorn nor Espree may want to make a breaking change.

Examples:

Actual Result

See above.

Additional Info

No response

Versions

package version
@typescript-eslint/parser 8.29.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    ASTPRs and Issues about the AST structurePRs and Issues about the AST structureaccepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuebugSomething isn't workingSomething isn't workingpackage: typescript-estreeIssues related to @typescript-eslint/typescript-estreeIssues related to @typescript-eslint/typescript-estree

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.