Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Enhancement: Allow specifying properties in TypeOrValueSpecifier #10740

Copy link
Copy link
Open
@koooge

Description

@koooge
Issue body actions

Before You File a Proposal Please Confirm You Have Done The Following...

My proposal is suitable for this project

  • I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Link to the rule's documentation

https://typescript-eslint.io/rules/no-floating-promises/#allowforknownsafepromises

Description

Hi there,
@typescript-eslint/no-floating-promises 's allowForKnownSafePromiseReturns #8404 works well for it from node:test. However, it doesn't help for it.only and it.skip. They are handy during debugging so it would be great to have the ability to ignore them as well.

  "allowForKnownSafePromiseReturns": [
    { "from": "package", "name": "it", "package": "node:test" }
  ]

Fail

import { it } from "node:test";

it.only("...", () => { /* ... */ });

it.skip("...", () => { /* ... */ });

Pass

import { it } from "node:test";

// eslint-disable-next-line @typescript-eslint/no-floating-promises
it.only("...", () => { /* ... */ });

// eslint-disable-next-line @typescript-eslint/no-floating-promises
it.skip("...", () => { /* ... */ });

Additional Info

No response

Harpush and lishaduck

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issueenhancement: plugin rule optionNew rule option for an existing eslint-plugin ruleNew rule option for an existing eslint-plugin rulepackage: eslint-pluginIssues related to @typescript-eslint/eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.