Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat(abg)!: replace data class perks by code generation in bindings #1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: vampire/binding-version-v2
Choose a base branch
Loading
from

Conversation

Vampire
Copy link
Collaborator

@Vampire Vampire commented Sep 6, 2024

Fixes #1629

Copy link
Collaborator Author

Vampire commented Sep 6, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Vampire Vampire force-pushed the vampire/no-data-bindings branch 2 times, most recently from fcb93fe to f2e6c05 Compare September 6, 2024 22:12
@Vampire Vampire force-pushed the vampire/versioned-routes branch from 6e0c383 to 05942ab Compare September 8, 2024 08:10
@Vampire Vampire force-pushed the vampire/no-data-bindings branch from f2e6c05 to f9bff8a Compare September 8, 2024 08:11
@Vampire Vampire changed the base branch from vampire/versioned-routes to vampire/binding-version-v2 September 8, 2024 08:11
@Vampire Vampire force-pushed the vampire/no-data-bindings branch 2 times, most recently from 26ff564 to 915be83 Compare September 8, 2024 15:23
@Vampire Vampire force-pushed the vampire/binding-version-v2 branch from 5b756f4 to a485fe4 Compare September 8, 2024 20:27
@Vampire Vampire force-pushed the vampire/no-data-bindings branch from 915be83 to 01e7a87 Compare September 8, 2024 20:27
@Vampire Vampire force-pushed the vampire/binding-version-v2 branch from a485fe4 to 6c58c0d Compare September 9, 2024 08:05
@Vampire Vampire force-pushed the vampire/no-data-bindings branch from 01e7a87 to 781eb1b Compare September 9, 2024 08:05
@Vampire Vampire force-pushed the vampire/binding-version-v2 branch from 6c58c0d to 66b9afd Compare September 9, 2024 10:57
@Vampire Vampire force-pushed the vampire/no-data-bindings branch from 781eb1b to 248813f Compare September 9, 2024 10:57
@Vampire Vampire force-pushed the vampire/binding-version-v2 branch from 66b9afd to f8e466f Compare September 10, 2024 16:43
@Vampire Vampire force-pushed the vampire/no-data-bindings branch from 248813f to a5da3b1 Compare September 10, 2024 16:43
@Vampire Vampire force-pushed the vampire/binding-version-v2 branch from f8e466f to eb02b5a Compare September 23, 2024 08:13
@Vampire Vampire force-pushed the vampire/no-data-bindings branch from a5da3b1 to f58ac6b Compare September 23, 2024 08:13
@Vampire Vampire force-pushed the vampire/binding-version-v2 branch from eb02b5a to 36a0a91 Compare September 24, 2024 00:41
@Vampire Vampire force-pushed the vampire/no-data-bindings branch from f58ac6b to f11c738 Compare September 24, 2024 00:41
@Vampire Vampire force-pushed the vampire/binding-version-v2 branch from 36a0a91 to 8895541 Compare September 29, 2024 17:29
@Vampire Vampire force-pushed the vampire/no-data-bindings branch from f11c738 to 5e87ccb Compare September 29, 2024 17:29
@Vampire Vampire force-pushed the vampire/binding-version-v2 branch from 8895541 to 4281b5d Compare September 29, 2024 21:12
@Vampire Vampire force-pushed the vampire/no-data-bindings branch from 5e87ccb to c89a7e1 Compare September 29, 2024 21:12
docs/user-guide/using-actions.md Outdated Show resolved Hide resolved
- The `equals` method will work like before.
- The `hashCode` method will work like before.
- The `toString` method will work like before.
- Destructuring assignments are not possible anymore as this will likely break silently or during
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initially wanted to ask why this change is made under v2 of the bindings server, and it's probably because of this remark about destructuring. I think it's enough to provide component1...componentN functions, then destructuring should work, and we wouldn't have to bump the route version just yet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My plan is to revisit our discussion we had on Slack to ensure that there's no simpler option to achieve what we want. Sometimes ideas come after time 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if someone has some interesting take on this: https://kotlinlang.slack.com/archives/C8C4JTXR7/p1729233924861659

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's enough to provide component1...componentN functions, then destructuring should work, and we wouldn't have to bump the route version just yet.

It would not be, as said on Slack.
It was intentional I left them out.
And additionally the copy method now also enforces named-arguments which is also a breaking change.
So to replicate here too, the goal here was not to somehow make it compatible with the upcoming Kotlin versions, but to improve the API to the originally intended way.
That this also fixes the copy visibility thing is merely a by-product and just was the trigger to finally have a look at it.

@Vampire Vampire force-pushed the vampire/binding-version-v2 branch from 4281b5d to 1f9acc7 Compare October 27, 2024 03:52
@Vampire Vampire force-pushed the vampire/no-data-bindings branch from c89a7e1 to fb71bbb Compare October 27, 2024 03:52
@Vampire Vampire force-pushed the vampire/no-data-bindings branch 2 times, most recently from 5fdc48f to 4fa6848 Compare April 30, 2025 18:08
@Vampire Vampire force-pushed the vampire/binding-version-v2 branch 2 times, most recently from 53c27b0 to c9e8a2f Compare May 1, 2025 22:25
@Vampire Vampire force-pushed the vampire/no-data-bindings branch 2 times, most recently from bce3f2f to 30806a5 Compare May 1, 2025 23:56
@Vampire Vampire force-pushed the vampire/binding-version-v2 branch from c9e8a2f to d0ef59a Compare May 1, 2025 23:56
@Vampire Vampire force-pushed the vampire/no-data-bindings branch from 30806a5 to 2f28590 Compare May 2, 2025 11:16
@Vampire Vampire force-pushed the vampire/binding-version-v2 branch from d0ef59a to 1e38b69 Compare May 2, 2025 11:16
@Vampire Vampire force-pushed the vampire/no-data-bindings branch from 2f28590 to 90c380f Compare May 2, 2025 11:51
@Vampire Vampire force-pushed the vampire/binding-version-v2 branch from 1e38b69 to 54a0d0e Compare May 2, 2025 11:52
@Vampire Vampire force-pushed the vampire/no-data-bindings branch from 90c380f to 83e3806 Compare May 2, 2025 12:34
@Vampire Vampire force-pushed the vampire/binding-version-v2 branch 2 times, most recently from 0af24c3 to 16cb955 Compare May 4, 2025 18:39
@Vampire Vampire force-pushed the vampire/no-data-bindings branch 2 times, most recently from 4210942 to d3ecf79 Compare May 6, 2025 13:09
@Vampire Vampire force-pushed the vampire/binding-version-v2 branch 2 times, most recently from 78db07b to 88a11f6 Compare May 12, 2025 12:32
@Vampire Vampire force-pushed the vampire/no-data-bindings branch from d3ecf79 to f72df5e Compare May 12, 2025 12:32
@Vampire Vampire force-pushed the vampire/binding-version-v2 branch from 88a11f6 to 5b5bb0f Compare May 12, 2025 12:39
@Vampire Vampire force-pushed the vampire/no-data-bindings branch from f72df5e to 3591e61 Compare May 12, 2025 12:39
@Vampire Vampire force-pushed the vampire/binding-version-v2 branch from 5b5bb0f to 2974c43 Compare May 12, 2025 15:26
@Vampire Vampire force-pushed the vampire/no-data-bindings branch from 3591e61 to 8df1350 Compare May 12, 2025 15:26
@Vampire Vampire force-pushed the vampire/binding-version-v2 branch from 2974c43 to 481b627 Compare May 14, 2025 13:23
@Vampire Vampire force-pushed the vampire/no-data-bindings branch from 8df1350 to dd21b0f Compare May 14, 2025 13:23
@Vampire Vampire force-pushed the vampire/binding-version-v2 branch from 481b627 to b4d13ce Compare May 20, 2025 09:49
@Vampire Vampire force-pushed the vampire/no-data-bindings branch from dd21b0f to 1542f03 Compare May 20, 2025 09:49
@Vampire Vampire force-pushed the vampire/binding-version-v2 branch from b4d13ce to e788dc0 Compare May 20, 2025 10:08
@Vampire Vampire force-pushed the vampire/no-data-bindings branch from 1542f03 to 98fc017 Compare May 20, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.