deprecated the ability to store non Node instances in Node::$nodes #2123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 19, 2016
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Sep 19, 2016
…g 1.25) (fabpot) This PR was merged into the 2.7 branch. Discussion ---------- [TwigBridge] removed Twig null nodes (deprecated as of Twig 1.25) | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes (more about removing deprecation notices from newer versions of Twig) | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a (see twigphp/Twig#2123) | License | MIT | Doc PR | n/a Commits ------- 12350c2 [TwigBridge] removed Twig null nodes (deprecated as of Twig 1.25)
a1543a1 to
03f18b4
Compare
fabpot
added a commit
that referenced
this pull request
Sep 19, 2016
…ode::$nodes (fabpot) This PR was merged into the 1.x branch. Discussion ---------- deprecated the ability to store non Node instances in Node::$nodes Commits ------- 03f18b4 enforced Node:: to only contain node instances
stof
reviewed
Sep 20, 2016
| @@ -37,6 +37,11 @@ class Twig_Node implements Twig_NodeInterface | ||
| */ | ||
| public function __construct(array $nodes = array(), array $attributes = array(), $lineno = 0, $tag = null) | ||
| { | ||
| foreach ($nodes as $name => $node) { | ||
| if (!$node instanceof Twig_NodeInterface) { |
There was a problem hiding this comment.
shouldn't you check for Twig_Node as the interface is deprecated ?
There was a problem hiding this comment.
The getNode method already says it returns a Twig_Node, not a Twig_NodeInterface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.