Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

vafanassieff
Copy link

@vafanassieff vafanassieff commented Sep 30, 2024

Hey there,

All tests are passing locally.
Please let me know if you need more from me.

Best.

Copy link

vercel bot commented Sep 30, 2024

@vafanassieff is attempting to deploy a commit to the ts-rest Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

changeset-bot bot commented Sep 30, 2024

⚠️ No Changeset found

Latest commit: e3e610c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vafanassieff vafanassieff force-pushed the main branch 2 times, most recently from f0090b6 to e977c9b Compare September 30, 2024 12:35
Copy link

@this-is-tobi
Copy link

Hey, any news about this one ?

@this-is-tobi
Copy link

Hey @oliverbutler, sorry to bother you and thanks for this awesome repository.

Can you give us some information about the maintenance / evolution of ts-rest, it seems like it's been almost 5 months since there has been a new version, are there any reasons for this ? Will it continue like this ? Should we consider making an official fork for the repository ?

In advance thanks for your answers, I wish you all the best for your projects 🪻

@aram-wealthmore
Copy link

@this-is-tobi npm install @ts-rest/fastify --legacy-peer-deps works for this was able to get it running.

A ping again to @oliverbutler, I was able to use v5 without issue with my routers

@oliverbutler oliverbutler self-assigned this Feb 9, 2025
Copy link
Collaborator

@oliverbutler oliverbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vafanassieff! Thanks for the PR.

Unfortunately due to the breaking changes in fastify v5, it seems like this would be a major version change to @ts-rest.

This may be a case of needing a @ts-rest/fastify v5 much like we've done for react-query v5.

What do you think?

@vafanassieff
Copy link
Author

Hi @vafanassieff! Thanks for the PR.

Unfortunately due to the breaking changes in fastify v5, it seems like this would be a major version change to @ts-rest.

This may be a case of needing a @ts-rest/fastify v5 much like we've done for react-query v5.

What do you think?

Hey, if we follow the semver spec it's indeed a major release, only for the @ts-rest/fastify package.

@oliverbutler
Copy link
Collaborator

@vafanassieff yup, however, we follow a single version policy so we have the exact same versions cross all of our packages (due to type sharing)

We'll likely have to copy/paste the fastify lib and make a v5.

I'm unsure whether our standard will be to have the v5 impl within the fastify lib e.g. @ts-rest/fastify/v5 or whether we just add a new @ts-rest/fastify-v5 package.

@Gabrola went with the /v5 subpath pattern with react-query so would be good to get that one agreed before moving forwards with this pr.

@jkazimierczak jkazimierczak mentioned this pull request Feb 22, 2025
@abdirahmn1
Copy link
Contributor

any updates on this?, i was very happy fastify was supported by ts-rest and then i found this issue 😂 😂 😂 😂

Thanks to all the maintainers ❤️

@egorFiNE
Copy link

I would love for this change to land, given it's more or less trivial.

@TheAsda
Copy link
Contributor

TheAsda commented May 14, 2025

Waiting for this change

@tandibar
Copy link

tandibar commented Jun 2, 2025

I don’t think this needs to be a breaking change. The library remains compatible with fastify v4, so users don’t have to upgrade to fastify v5. The only required adjustment is to relax the version constraint in the package.json to allow fastify >= 4.0.0.

Or am I overlooking something?

@mabilalmirza
Copy link

I just started implementing a backend with ts-rest v3.52.1 and fastify v5.4.0. Things are working fine so far (I am just in initial stages). But following pnpm warning lead me to this feature request thread.

 WARN  Issues with peer dependencies found
xyz-backend
└─┬ @ts-rest/fastify 3.52.1
  └── ✕ unmet peer fastify@^4.0.0: found 5.4.0

I have read the comments and now I am confused whether to continue with it or not.

@barthofu
Copy link

Same, i didn't have any issues so far.

Maybe just relax the version constraint?

"license": "MIT",
"peerDependencies": {
"fastify": "^4.0.0",
"fastify": "^5.0.0",
Copy link
Contributor

@bestickley bestickley Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you change this to "^4.0.0 || ^5.0.0" to prevent breaking change?

@msaspence
Copy link

Any chance this can get over the line 🙏

Looks like just the version constraint needs relaxing?

@kibertoad
Copy link

@oliverbutler Is there anything that can be done to help push this over the finish line? I'm happy to help create separate fastify5 package if that is how is preferable to proceed.

@kibertoad
Copy link

Btw, I've created an alternative PR that avoids breaking changes and just bumps the range: #850

It should work at a runtime, but produce non-ideal types for Replies. Full solution would require merging this PR in some form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Morty Proxy This is a proxified and sanitized view of the page, visit original site.