fix to set HMAC#60
Open
bugrasan wants to merge 1 commit intotrustcrypto:mastertrustcrypto/python-onlykey:masterfrom
bugrasan:set-privkey-hmac-fixbugrasan/python-onlykey:set-privkey-hmac-fixCopy head branch name to clipboard
Open
fix to set HMAC#60bugrasan wants to merge 1 commit intotrustcrypto:mastertrustcrypto/python-onlykey:masterfrom bugrasan:set-privkey-hmac-fixbugrasan/python-onlykey:set-privkey-hmac-fixCopy head branch name to clipboard
bugrasan wants to merge 1 commit intotrustcrypto:mastertrustcrypto/python-onlykey:masterfrom
bugrasan:set-privkey-hmac-fixbugrasan/python-onlykey:set-privkey-hmac-fixCopy head branch name to clipboard
Conversation
this will fix setting the private key HMAC; while setting HMAC we don't need the key_feature. however the setkey function in client.py was expecting a key_feature.
Author
|
more information regarding users having trouble uploading HMAC keys in the forum: https://onlykey.discourse.group/t/cant-configure-the-challenge-response-with-onlykey-cli/306 |
|
Is this project abandoned? I found this PR, because I have trouble setting HMAC-keys in the cli-version of the app, too. |
Author
|
don't know 🤷♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix setting the private key HMAC;
While setting HMAC we don't need the key_feature.
However the setkey function in client.py was expecting a key_feature.
This was the quickest fix, but probably not the most elegant. Further code cleanup might be required and might follow.
PS: I just tested the use case for setting HMAC, proper testing for other priv key types should be done.