Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Upgrade trunk to 1.24.1-beta.5 #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
Loading
from

Conversation

trunk-open-pr-bot[bot]
Copy link
Contributor

@trunk-open-pr-bot trunk-open-pr-bot bot commented Feb 26, 2025

Trunk

cli upgraded: 1.22.15 → 1.24.1-beta.5

2 linters were upgraded:

  • eslint 9.27.0 → 9.28.0
  • pmd pmd_releases/7.12.0 → pmd_releases/7.14.0

1 plugin was upgraded:

  • trunk-io/configs v1.0.12 → v1.1.0

This PR was generated by the Trunk Action. For more info, see our docs or reach out on Slack.

Copy link

trunk-io bot commented Feb 26, 2025

⏱️ 1h 8m total CI duration on this PR
Job Cumulative Duration Recent Runs
Linter Tests ubuntu-latest 22m 🟩
Linter Tests macOS 20m 🟩
Tool Tests (ubuntu-latest) 11m 🟩
Tool Tests (macOS) 6m 🟩
Action Tests 3m 🟩🟩
CodeQL-Build 3m 🟩🟩
Trunk Check runner [linux] 2m 🟩🟩
Repo Tests / Plugin Tests 38s 🟩
Detect changed files 8s 🟩🟩
Aggregate Test Results 1s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link

trunk-staging-io bot commented Feb 26, 2025

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
Testing linter nancy test CUSTOM Error: expect(received).toMatchSnapshot(properties) - Snapshot name: 'Testing linter nancy test CUSTOM 1' - Snapshot - 9, Received + 33 Logs ↗︎

View Full Report ↗︎Docs

Copy link

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

1 similar comment
Copy link

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

Copy link

trunk-io bot commented Feb 26, 2025

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
Testing linter nancy test CUSTOM Error: expect(received).toMatchSnapshot(properties) - Snapshot name: 'Testing linter nancy test CUSTOM 1' - Snapshot - 9, Received + 33 Logs ↗︎

View Full Report ↗︎Docs

@trunk-open-pr-bot trunk-open-pr-bot bot changed the title Upgrade trunk to 1.22.11-beta.7 Upgrade trunk to 1.22.11-beta.11 Mar 5, 2025
@trunk-open-pr-bot trunk-open-pr-bot bot force-pushed the trunk-io/update-trunk branch from bc2e4ee to d397042 Compare March 5, 2025 10:04
@trunk-open-pr-bot trunk-open-pr-bot bot changed the title Upgrade trunk to 1.22.11-beta.11 Upgrade trunk to 1.22.11-beta.14 Mar 12, 2025
@trunk-open-pr-bot trunk-open-pr-bot bot force-pushed the trunk-io/update-trunk branch from d397042 to 7db1098 Compare March 12, 2025 10:04
@trunk-open-pr-bot trunk-open-pr-bot bot changed the title Upgrade trunk to 1.22.11-beta.14 Upgrade trunk to 1.22.12-beta.1 Mar 19, 2025
@trunk-open-pr-bot trunk-open-pr-bot bot force-pushed the trunk-io/update-trunk branch 2 times, most recently from ba987a4 to e9ffdbf Compare March 26, 2025 10:04
@trunk-open-pr-bot trunk-open-pr-bot bot changed the title Upgrade trunk to 1.22.12-beta.1 Upgrade trunk to 1.22.12-beta.5 Mar 26, 2025
@trunk-open-pr-bot trunk-open-pr-bot bot changed the title Upgrade trunk to 1.22.12-beta.5 Upgrade trunk to 1.22.12-beta.11 Apr 2, 2025
@trunk-open-pr-bot trunk-open-pr-bot bot force-pushed the trunk-io/update-trunk branch from e9ffdbf to fd2f551 Compare April 2, 2025 10:04
@trunk-open-pr-bot trunk-open-pr-bot bot force-pushed the trunk-io/update-trunk branch from fd2f551 to f3d7739 Compare April 9, 2025 10:05
@trunk-open-pr-bot trunk-open-pr-bot bot changed the title Upgrade trunk to 1.22.12-beta.11 Upgrade trunk to 1.22.13-beta.6 Apr 9, 2025
@trunk-open-pr-bot trunk-open-pr-bot bot force-pushed the trunk-io/update-trunk branch from f3d7739 to 2dc9d51 Compare April 16, 2025 10:04
@trunk-open-pr-bot trunk-open-pr-bot bot changed the title Upgrade trunk to 1.22.13-beta.6 Upgrade trunk to 1.22.13-beta.8 Apr 16, 2025
@trunk-open-pr-bot trunk-open-pr-bot bot force-pushed the trunk-io/update-trunk branch from 2dc9d51 to f1d1693 Compare April 23, 2025 10:04
@trunk-open-pr-bot trunk-open-pr-bot bot changed the title Upgrade trunk to 1.22.13-beta.8 Upgrade trunk to 1.22.13-beta.17 Apr 23, 2025
@trunk-open-pr-bot trunk-open-pr-bot bot requested a review from TylerJang27 April 23, 2025 10:04
Copy link

chip-agent bot commented Apr 23, 2025

Summary:
The PR upgrades the trunk cli version, some linters (eslint, pmd), and the trunk-io/configs plugin. It also adds java@13.0.11 to the enabled runtimes.

Root Cause Analysis:
Without test logs, it's difficult to pinpoint the exact cause of the flaky tests. However, the changes in this PR could potentially lead to flakiness in a few ways:

  1. Linter Version Upgrades: Upgrading linters like eslint and pmd could introduce new rules or change existing rule behavior. This might cause existing code to fail linting checks intermittently, especially if the codebase isn't perfectly compliant with the stricter rules.
  2. Trunk CLI Upgrade: The trunk CLI upgrade could also introduce subtle changes in how linters are executed or how results are reported, leading to inconsistent test outcomes.
  3. New Java Runtime: Adding a new Java runtime could expose compatibility issues or subtle differences in behavior that cause tests to fail sporadically.

Resolution Plan:

Since I don't have access to the test logs, I can only provide general recommendations.

  1. Re-run the tests: The first step is always to re-run the tests to see if the flakiness persists. It's possible that the failures were transient and won't reappear.
  2. Examine the test logs: If the tests continue to fail, try to get the test logs. Look for patterns in the failures. Are the same tests failing consistently? Are there any error messages that provide clues about the root cause?
  3. Investigate linter changes: If the failures seem related to linting, investigate the changes in eslint and pmd versions. Check their release notes for any breaking changes or new rules that might be affecting the codebase.
  4. Consider specific files: If specific files are failing, use the fileContentTool to examine those files and see if the new linter versions are flagging any new issues.
  5. Check Java compatibility: If the failures seem related to Java, investigate the compatibility of the codebase with Java 13.0.11. Look for any known issues or differences in behavior that might be causing the tests to fail.

If the user can provide the test logs, I can provide a more specific and actionable resolution plan.


Is this helpful? Click the 👍/👎 buttons below to let us know!

Thumbs UpThumbs Down

Icons by Icons8

@trunk-open-pr-bot trunk-open-pr-bot bot changed the title Upgrade trunk to 1.22.13-beta.17 Upgrade trunk to 1.22.14-beta.3 Apr 30, 2025
@trunk-open-pr-bot trunk-open-pr-bot bot force-pushed the trunk-io/update-trunk branch from f1d1693 to ce7f7ad Compare April 30, 2025 10:04
@trunk-open-pr-bot trunk-open-pr-bot bot changed the title Upgrade trunk to 1.22.14-beta.3 Upgrade trunk to 1.22.16-beta.4 May 7, 2025
@trunk-open-pr-bot trunk-open-pr-bot bot force-pushed the trunk-io/update-trunk branch from ce7f7ad to ed57839 Compare May 7, 2025 10:04
@trunk-open-pr-bot trunk-open-pr-bot bot changed the title Upgrade trunk to 1.22.16-beta.4 Upgrade trunk to 1.22.16-beta.8 May 14, 2025
@trunk-open-pr-bot trunk-open-pr-bot bot force-pushed the trunk-io/update-trunk branch from ed57839 to 1af3801 Compare May 14, 2025 10:04
Copy link

trunk-staging-io bot commented May 14, 2025

Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information.

@trunk-open-pr-bot trunk-open-pr-bot bot changed the title Upgrade trunk to 1.22.16-beta.8 Upgrade trunk to 1.22.16-beta.10 May 21, 2025
@trunk-open-pr-bot trunk-open-pr-bot bot force-pushed the trunk-io/update-trunk branch from 1af3801 to d5bdc5e Compare May 21, 2025 10:04
@trunk-open-pr-bot trunk-open-pr-bot bot changed the title Upgrade trunk to 1.22.16-beta.10 Upgrade trunk to 1.22.16-beta.15 May 28, 2025
@trunk-open-pr-bot trunk-open-pr-bot bot force-pushed the trunk-io/update-trunk branch 2 times, most recently from 4b45b11 to 59ebea2 Compare June 4, 2025 10:04
@trunk-open-pr-bot trunk-open-pr-bot bot changed the title Upgrade trunk to 1.22.16-beta.15 Upgrade trunk to 1.23.1-beta.4 Jun 4, 2025

runtimes:
enabled:
- java@13.0.11
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an unexpected change?

@trunk-open-pr-bot trunk-open-pr-bot bot changed the title Upgrade trunk to 1.23.1-beta.4 Upgrade trunk to 1.24.1-beta.5 Jun 11, 2025
@trunk-open-pr-bot trunk-open-pr-bot bot force-pushed the trunk-io/update-trunk branch from 59ebea2 to 022f51a Compare June 11, 2025 10:05
@trunk-open-pr-bot trunk-open-pr-bot bot requested a review from TylerJang27 June 11, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant
Morty Proxy This is a proxified and sanitized view of the page, visit original site.