Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix(db/trans-cache): avoid recovering a wrong cached data #5505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
halibobo1205 merged 1 commit into from
Sep 20, 2023
Merged

fix(db/trans-cache): avoid recovering a wrong cached data #5505

halibobo1205 merged 1 commit into from
Sep 20, 2023

Conversation

@halibobo1205
Copy link
Contributor

@halibobo1205 halibobo1205 commented Sep 19, 2023

Avoid downgrading and then upgrading to use the wrong data for cache recovery

For the following cases ：

  1. start node with 4.7.3
  2. stop node with kill -15 : dump trans-cache data on header x
  3. start node with 4.7.2
  4. stop node on header y(y>x)
  5. start node with 4.7.3: recover trans-cache data with header x, DupTransactionException will possibly occur.

How to fix

Check header when recovering cached data.

@halibobo1205 halibobo1205 self-assigned this Sep 19, 2023
@halibobo1205 halibobo1205 added this to the GreatVoyage-v4.7.3 milestone Sep 19, 2023
@halibobo1205 halibobo1205 merged commit 703a866 into tronprotocol:release_v4.7.3 Sep 20, 2023
@halibobo1205 halibobo1205 mentioned this pull request Oct 9, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@forfreeday forfreeday Awaiting requested review from forfreeday

3 more reviewers

@tomatoishealthy tomatoishealthy tomatoishealthy approved these changes

@xxo1shine xxo1shine xxo1shine approved these changes

@jwrct jwrct jwrct approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@halibobo1205 halibobo1205

Labels

type:bug

Projects

None yet

Milestone

GreatVoyage-v4.7.3

Development

Successfully merging this pull request may close these issues.

4 participants

@halibobo1205 @tomatoishealthy @xxo1shine @jwrct
Morty Proxy This is a proxified and sanitized view of the page, visit original site.