Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@xxo1shine
Copy link
Contributor

@xxo1shine xxo1shine commented Aug 8, 2023

What does this PR do?
Fix getHeadBlockId abnormal return problem, fix #5389.

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.90%. Comparing base (10223cc) to head (5ce3ff0).
⚠️ Report is 566 commits behind head on develop.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #5403   +/-   ##
==========================================
  Coverage      60.89%   60.90%           
+ Complexity      9231     9230    -1     
==========================================
  Files            839      839           
  Lines          50029    50027    -2     
  Branches        5574     5574           
==========================================
  Hits           30467    30467           
+ Misses         17176    17173    -3     
- Partials        2386     2387    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lvs007 lvs007 requested review from halibobo1205 and jwrct August 9, 2023 03:30
Copy link
Contributor

@halibobo1205 halibobo1205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@halibobo1205 halibobo1205 added this to the GreatVoyage-v4.7.3 milestone Aug 9, 2023
@halibobo1205
Copy link
Contributor

halibobo1205 commented Aug 9, 2023

fix #5389

@xxo1shine xxo1shine merged commit f33c169 into tronprotocol:develop Aug 11, 2023
@xxo1shine xxo1shine deleted the fix_getHeadBlockId branch May 28, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

getHeadBlockId abnormal return

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.