Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Discussion options

First, thank you very much for building such an awesome, well-thought-out tool. I have a question regarding the generation of canonical page ids.

When it encounters a page whose canonical page id has already been in the map, it will simply issue a warning, for example:

error duplicate canonical page id {
  canonicalPageId: 'circular-queue-implementation-in-javascript',
  pageId: 'a6a3e620-866d-426e-8bf3-490883b11d80',
  existingPageId: '4f2b40d9-b282-4143-9737-3c0bf79cd9ce'
}

The page with the duplicate canonical page id won't be built. I can understand the rationale behind it, but the warning doesn't stand out very much when you've already console.log several other values during the build process. It's quite possible that the user may miss out on this warning.

There is nothing in Notion that helps user check for duplicate property values that I'm aware of. As the number of pages increase, the probability of duplicate name becomes higher. Should this kit be more stringent about duplicate page names? Like throw an error and quit the build.

You must be logged in to vote

Replies: 0 comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
🙏
Q&A
Labels
None yet
1 participant
Morty Proxy This is a proxified and sanitized view of the page, visit original site.