Support fcntl check on Emscripten #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
25 tasks
gaborbernat
requested changes
Feb 19, 2025
Member
gaborbernat
left a comment
There was a problem hiding this comment.
Seems the CI does not like your changes 🤔
Contributor
Author
Whoops, I managed to mistype |
gaborbernat
approved these changes
Feb 19, 2025
Contributor
Author
|
@gaborbernat Is there a rough timeline for when the next version of filelock will be released? |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Pyodide/Emscripten, file locking is not (yet) supported (see e.g. pyodide/pyodide#4150 (comment)).
This PR extends the
fcntlimport check to also test whether the locking APIs are available, so that the soft locking fallback can be used if they are not. As a result, thefilelockpackage becomes usable in Pyodide/Emscripten.