Add nat to the default [IN|E]GRESS_CAKE_OPTS in defaults.sh#169
Merged
Add nat to the default [IN|E]GRESS_CAKE_OPTS in defaults.sh#169
Conversation
Also change piece_of_cake.qos to evaluate [IN|E]GRESS_CAKE_OPTS Signed-off-by: Sebastian Moeller <moeller0@gmx.de>
Collaborator
Author
|
Thanks, one special option less to teach almost everybody to add ;) |
Collaborator
|
thx. Also diffserv4 is now the default across libreqos. |
Collaborator
Author
|
So while I run with diffserv3 I rarely consciously actually steer anything purposefully (I really just want the capability to react quickly in case I need to), I am rather unattached to the exact number of priority tiers (as long as it stays smallish, especially on slow links too many tiers will hurt more than they help...). I liked diffserv3 as it really has this balanced notion of one `normal`tier and one above and one below...
So what is your pitch for using diffserv4 as default? (I am happy to roll a PR to change the default, but Toke is the final arbiter/decider (by virtue of taste ;)))...
… On 19. Feb 2024, at 20:00, Dave Täht ***@***.***> wrote:
thx. Also diffserv4 is now the default across libreqos.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Collaborator
|
CS4 and CS5 are videoconferencing marks. |
Collaborator
Author
|
Hi Dave,
On 20. Feb 2024, at 22:08, Dave Täht ***@***.***> wrote:
CS4 and CS5 are videoconferencing marks.
Yes? Zoom for non-payers defaults to no DSCPs and in my experience still works pretty well (on a 100 Mbps vdsl2 link).
Diffserv4 actually puts CS4 ans CS5 into the Voice tin:
static int cake_config_diffserv4(struct Qdisc *sch)
{
/* Further pruned list of traffic classes for four-class system:
*
* Latency Sensitive (CS7, CS6, EF, VA, CS5, CS4)
* Streaming Media (AF4x, AF3x, CS3, AF2x, TOS4, CS2, TOS1)
* Best Effort (CS0, AF1x, TOS2, and those not specified)
* Background Traffic (CS1)
*
* Total 4 traffic classes.
Not sure that is actually what we should want on low rate links...
(That said, I rarely use DSCPs so might be missing the utility due to having a fast enough link to not having to care).
… —
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Collaborator
|
sigh. I had been thinking about this wrong for ages, then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For most users the nat lookup seems to be the best default, so add nat to the default cake options in defaults.sh. piece_of_cake was ignoring these cake options so far, instead simply append the besteffort keyword to INGRESS_CAKE_OPTS and EGRESS_CAKE_OPTS which will retain all other defaults...