Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

asnmap: add page #16475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 13, 2025
Merged

asnmap: add page #16475

merged 5 commits into from
May 13, 2025

Conversation

MachiavelliII
Copy link
Member

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@MachiavelliII MachiavelliII requested a review from fazlearefin May 12, 2025 08:42
@MachiavelliII MachiavelliII requested a review from cyqsimon as a code owner May 12, 2025 08:42
@github-actions github-actions bot added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label May 12, 2025
@tldr-bot
Copy link

Hello! I've noticed something unusual when checking this PR:

  • The page pages/linux/searchsploit.md already exists in the common directory.

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

@MachiavelliII MachiavelliII mentioned this pull request May 12, 2025
Open
@fazlearefin
Copy link
Member

fazlearefin commented May 12, 2025 •
edited
Loading

Hi @MachiavelliII
Although I couldn't find anything exclipit in the guides, I think it is good practice to have separate PRs for separate brand new commands. This not only makes it easier for the reviewers but also makes it easy to link to the commit from the Issues pages (such as this one #6863)

And the tldr-bot also mentioned searchsploit already exists in common.

@MachiavelliII MachiavelliII changed the title searchsploit, asnmap: add page asnmap: add page May 12, 2025
fazlearefin
fazlearefin requested changes May 13, 2025
View reviewed changes
pages/common/asnmap.md Show resolved Hide resolved
pages/common/asnmap.md Outdated Show resolved Hide resolved
pages/common/asnmap.md Outdated Show resolved Hide resolved
pages/common/asnmap.md Outdated Show resolved Hide resolved
pages/common/asnmap.md Outdated Show resolved Hide resolved
pages/common/asnmap.md Outdated Show resolved Hide resolved
pages/common/asnmap.md Outdated Show resolved Hide resolved
pages/common/asnmap.md Outdated Show resolved Hide resolved
pages/common/asnmap.md Outdated Show resolved Hide resolved
MachiavelliII and others added 2 commits May 13, 2025 10:21
@MachiavelliII @fazlearefin
Update pages/common/asnmap.md
bec1218 
Co-authored-by: Fazle Arefin <fazlearefin@users.noreply.github.com>
@MachiavelliII
Update asnmap.md
192cf3b
@MachiavelliII MachiavelliII requested a review from fazlearefin May 13, 2025 07:22
fazlearefin
fazlearefin approved these changes May 13, 2025
View reviewed changes
Copy link
Member

@fazlearefin fazlearefin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need this change as well.

pages/common/asnmap.md Outdated Show resolved Hide resolved
@MachiavelliII @fazlearefin
Update pages/common/asnmap.md
3a88112 
Co-authored-by: Fazle Arefin <fazlearefin@users.noreply.github.com>
@MachiavelliII MachiavelliII merged commit f41f43d into tldr-pages:main May 13, 2025
4 checks passed
@MachiavelliII MachiavelliII deleted the p-np branch May 13, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fazlearefin fazlearefin fazlearefin approved these changes

@sebastiaanspeck sebastiaanspeck sebastiaanspeck approved these changes

@cyqsimon cyqsimon Awaiting requested review from cyqsimon

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MachiavelliII @tldr-bot @fazlearefin @sebastiaanspeck
Morty Proxy This is a proxified and sanitized view of the page, visit original site.