Keep NULL values as nil when typecasting#28
Open
lsimoneau wants to merge 1 commit intotlconnor:mastertlconnor/activerecord-postgres-array:masterfrom
Open
Keep NULL values as nil when typecasting#28lsimoneau wants to merge 1 commit intotlconnor:mastertlconnor/activerecord-postgres-array:masterfrom
lsimoneau wants to merge 1 commit intotlconnor:mastertlconnor/activerecord-postgres-array:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, NULL values in the DB arrays were correctly converted to nil in String#from_postgres_array, however this would result either in an error (with e.g. floats) or an incorrect value (with e.g. integers, as nil.to_i => 0).
This preserves NULL values as nil in the resulting Ruby array, and also adds spec coverage for all of the existing typecasting behaviour.