Hydrosquall optimize unique chars#6
Open
hydrosquall wants to merge 2 commits intothundergolfer:masterthundergolfer/interview-with-python:masterfrom
hydrosquall:hydrosquall-optimize-unique-charshydrosquall/interview-with-python:hydrosquall-optimize-unique-charsCopy head branch name to clipboard
Open
Hydrosquall optimize unique chars#6hydrosquall wants to merge 2 commits intothundergolfer:masterthundergolfer/interview-with-python:masterfrom hydrosquall:hydrosquall-optimize-unique-charshydrosquall/interview-with-python:hydrosquall-optimize-unique-charsCopy head branch name to clipboard
hydrosquall wants to merge 2 commits intothundergolfer:masterthundergolfer/interview-with-python:masterfrom
hydrosquall:hydrosquall-optimize-unique-charshydrosquall/interview-with-python:hydrosquall-optimize-unique-charsCopy head branch name to clipboard
Conversation
Was thinking about this problem recently, so added a small constraint that avoids checking strings that must have duplicates by virtue of the fact that they are too long. Alternately, if it would be best to code up a separate solution in a different file, I could do that too.
There are 256, not 255 characters The classic CS off-by-one error strikes again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
Sorry I goofed in the previous PR #5 !
There are 256, not 255 ASCII characters. The classic CS "off-by-one" error strikes again!