Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix venv wrapper reset retval error with gym env#712

Merged
Trinkle23897 merged 2 commits intothu-ml:masterthu-ml/tianshou:masterfrom
Trinkle23897:fix-gym-reset-infoTrinkle23897/tianshou:fix-gym-reset-infoCopy head branch name to clipboard
Jul 31, 2022
Merged

Fix venv wrapper reset retval error with gym env#712
Trinkle23897 merged 2 commits intothu-ml:masterthu-ml/tianshou:masterfrom
Trinkle23897:fix-gym-reset-infoTrinkle23897/tianshou:fix-gym-reset-infoCopy head branch name to clipboard

Conversation

@Trinkle23897
Copy link
Copy Markdown
Collaborator

Close #697

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 31, 2022

Codecov Report

Merging #712 (d384cc2) into master (f270e88) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #712   +/-   ##
=======================================
  Coverage   93.23%   93.23%           
=======================================
  Files          72       72           
  Lines        4895     4895           
=======================================
  Hits         4564     4564           
  Misses        331      331           
Flag Coverage Δ
unittests 93.23% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tianshou/data/collector.py 94.24% <ø> (ø)
tianshou/env/venvs.py 94.07% <ø> (ø)
tianshou/env/venv_wrappers.py 83.33% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Trinkle23897 Trinkle23897 merged commit 0f59e38 into thu-ml:master Jul 31, 2022
@Trinkle23897 Trinkle23897 deleted the fix-gym-reset-info branch July 31, 2022 18:00
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
* Fix venv wrapper reset retval error with gym env

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error in obs norm

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.