[DO NOT MERGE] Review rebased draft#228
Closed
lukpueh wants to merge 3 commits intotheupdateframework:mastertheupdateframework/specification:masterfrom
Closed
[DO NOT MERGE] Review rebased draft#228lukpueh wants to merge 3 commits intotheupdateframework:mastertheupdateframework/specification:masterfrom
lukpueh wants to merge 3 commits intotheupdateframework:mastertheupdateframework/specification:masterfrom
Conversation
Update "4.5. File formats: targets.json and delegated target roles" to reflect metadata format introduced by TAP 3
Clarify in step 5.6.7.2.1 of the client workflow that in a multi-role delegation not each but rather a defined threshold of roles must agree on the target hashes and lengths (see `min_roles_in_agreement`).
`keys_for_delegations` --> `keys` (the keys field in root.json in reality also lists "keys for delegations", i.e. keys to delegate trust to other top-level roles, but is only called keys) `roleinfo` --> `roles` (keeping the name for delegated roles as it was before TAP3)
JustinCappos
approved these changes
May 24, 2022
Member
JustinCappos
left a comment
There was a problem hiding this comment.
The changes look good to me.
Member
Author
|
Thanks, @JustinCappos!
|
Member
|
Many thanks for doing the work here @lukpueh! We really need that automation :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
draftbranch is notoriously lagging behind (currently 39 commits). This PR shows the rebaseddraftbranch against the up-to-date master. Its diff should look roughly the same as old draft against old master, modulo some changes due to resolving rebase conflicts.Upon approval I will force-push draft rather than merging this PR.