Update to Laravel 6 & 7, + PHP 7.4 compatible #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addressing #94 |
|
Travis fails on PHP 5.6. Maybe will be better to just remove 5.6 from Travis config, because Laravel 6 supports PHP 7.2+ |
Updated php-versions.
Fixed PHP 7.4 compatibility, for: ErrorException: Unparenthesized `a ? b : c ? d : e` is deprecated
Added Travis CI badge.
Added Travis CI badge.
Closed
|
Merging this does fix the issue, as it is only a parenthesis error in the ternary condition. Please accept it so we can update in our composer json. Thank you. |
|
Please help to release it to packagist. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be nice to have.
What I could notice no big changes and tests passed.