[bugfix] build rpcapd static on Windows #1056
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the build system tries to link `rpcapd ` to the shared version of `libpcap` unconditionally, but this library is not created in a static build `-DBUILD_SHARED_LIBS=OFF`
blackliner
commented
Oct 25, 2021
Comment on lines
+115
to
+121
| if(WIN32 AND BUILD_SHARED_LIBS) | ||
| target_link_libraries(rpcapd ${LIBRARY_NAME} | ||
| ${RPCAPD_LINK_LIBRARIES} ${PCAP_LINK_LIBRARIES} ${CMAKE_THREAD_LIBS_INIT}) | ||
| else(WIN32) | ||
| else(WIN32 AND BUILD_SHARED_LIBS) | ||
| target_link_libraries(rpcapd ${LIBRARY_NAME}_static | ||
| ${RPCAPD_LINK_LIBRARIES} ${PCAP_LINK_LIBRARIES} ${CMAKE_THREAD_LIBS_INIT}) | ||
| endif(WIN32) | ||
| endif(WIN32 AND BUILD_SHARED_LIBS) |
There was a problem hiding this comment.
Alternatively, why not link to ${LIBRARY_NAME}_static all the time? Like this:
target_link_libraries(rpcapd ${LIBRARY_NAME}_static
${RPCAPD_LINK_LIBRARIES} ${PCAP_LINK_LIBRARIES} ${CMAKE_THREAD_LIBS_INIT})
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the build system tries to link
rpcapdto the shared version oflibpcapunconditionally, but this library is not created in a static build-DBUILD_SHARED_LIBS=OFFWhy don't you just link to the static version all the time, did you have any issues in the past?