Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e5e1e42

Browse filesBrowse files
authored
Merge pull request FriendsOfSymfony#565 from FriendsOfSymfony/fix-build
fix build with symfony 5
2 parents 5d1f628 + dcd6513 commit e5e1e42
Copy full SHA for e5e1e42

File tree

Expand file treeCollapse file tree

3 files changed

+21
-1
lines changed
Filter options
Expand file treeCollapse file tree

3 files changed

+21
-1
lines changed

‎.github/workflows/php.yml

Copy file name to clipboardExpand all lines: .github/workflows/php.yml
+5Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,3 +60,8 @@ jobs:
6060
if: ${{ matrix.stability != 'dev' }}
6161
- name: Run tests
6262
run: php vendor/bin/simple-phpunit -v
63+
if: ${{ matrix.stability != 'dev' }}
64+
- name: Run tests allow to fail
65+
run: php vendor/bin/simple-phpunit -v || true
66+
continue-on-error: true
67+
if: ${{ matrix.stability == 'dev' }}

‎tests/Functional/Fixtures/app/AppKernel.php

Copy file name to clipboardExpand all lines: tests/Functional/Fixtures/app/AppKernel.php
+3-1Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,9 @@ public function registerBundles()
5656
*/
5757
public function registerContainerConfiguration(LoaderInterface $loader)
5858
{
59-
if (\version_compare(Kernel::VERSION, '4.1', '>=')) {
59+
if (\version_compare(Kernel::VERSION, '5.0', '>=')) {
60+
$loader->load(__DIR__.'/config/config_50.yml');
61+
} elseif (\version_compare(Kernel::VERSION, '4.1', '>=')) {
6062
$loader->load(__DIR__.'/config/config_41.yml');
6163
} elseif (\version_compare(Kernel::VERSION, '4.0', '>=')) {
6264
$loader->load(__DIR__.'/config/config_40.yml');
+13Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
# configuration to make symfony 5.0 work as expected
2+
3+
imports:
4+
- { resource: config.yml }
5+
6+
framework:
7+
router:
8+
resource: "%kernel.project_dir%/tests/Functional/Fixtures/app/config/routing_41.yml"
9+
annotations: ~
10+
11+
twig:
12+
default_path: "%kernel.project_dir%/tests/Functional/Fixtures/app/Resources/views"
13+
strict_variables: "%kernel.debug%"

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.