fix: make library compatible with Node 8#587
Merged
joshuaellis merged 1 commit intotesting-library:mastertesting-library/react-hooks-testing-library:masterfrom Mar 29, 2021
yoniholmes:pr/node-8-compatibleyoniholmes/react-hooks-testing-library:pr/node-8-compatibleCopy head branch name to clipboard
Merged
fix: make library compatible with Node 8#587joshuaellis merged 1 commit intotesting-library:mastertesting-library/react-hooks-testing-library:masterfrom yoniholmes:pr/node-8-compatibleyoniholmes/react-hooks-testing-library:pr/node-8-compatibleCopy head branch name to clipboard
joshuaellis merged 1 commit intotesting-library:mastertesting-library/react-hooks-testing-library:masterfrom
yoniholmes:pr/node-8-compatibleyoniholmes/react-hooks-testing-library:pr/node-8-compatibleCopy head branch name to clipboard
Conversation
Codecov Report
@@ Coverage Diff @@
## master #587 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 219 219
Branches 29 29
=========================================
Hits 219 219
Continue to review full report at Codecov.
|
joshuaellis
approved these changes
Mar 29, 2021
Member
joshuaellis
left a comment
There was a problem hiding this comment.
Thanks for the contribution! ⭐
Contributor
Author
|
No problems! Thanks for the library! Cheers, Jonathan
…On Mon, 29 Mar 2021 at 18:42, Josh ***@***.***> wrote:
***@***.**** approved this pull request.
Thanks for the contribution! ⭐
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#587 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABNCDK242MAFXXQVNVYTDDTGDCZXANCNFSM4Z7XY77Q>
.
|
|
🎉 This PR is included in version 5.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Tweak to make library compatible with Node 8
Why:
I'm using your library in an environment which for reasons can only run on Node 8.
How:
A minor syntax change ensures the library works in Node 8.
Checklist: