Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix(no-node-access): exclude user to avoid false positives #1025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025

Conversation

y-hsgw
Copy link
Member

@y-hsgw y-hsgw commented Jun 10, 2025

I have applied the temporary workaround that was proposed in #1024.
Sorry for the inconvenience, but I would appreciate your review.πŸ™‡β€β™‚οΈ

Checks

Changes

  • Temporarily exclude the variable name 'user' from the no-node-access rule to avoid false positive errors when using const user = userEvent.setup().

Context

#1024 (partiallyοΌ‰

Copy link

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 96.30%. Comparing base (934bc5e) to head (dbb1c7f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1025   +/-   ##
=======================================
  Coverage   96.30%   96.30%           
=======================================
  Files          47       47           
  Lines        2541     2543    +2     
  Branches     1051     1051           
=======================================
+ Hits         2447     2449    +2     
  Misses         94       94           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks πŸ™

lib/rules/no-node-access.ts Show resolved Hide resolved
@Belco90 Belco90 changed the title fix(no-node-access): Temporarily exclude 'user' from no-node-access rule to avoid false positives fix(no-node-access): exclude user to avoid false positives Jun 10, 2025
@Belco90 Belco90 merged commit 67f08f9 into testing-library:main Jun 10, 2025
31 checks passed
Copy link

πŸŽ‰ This PR is included in version 7.5.1 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

@y-hsgw y-hsgw deleted the pr/fix-no-node-access branch June 10, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.