Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat: Support additional cluster DNS IPs with Bottlerocket based AMIs #3051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 28, 2024
Merged

feat: Support additional cluster DNS IPs with Bottlerocket based AMIs #3051

merged 4 commits into from
May 28, 2024

Conversation

ramseymcgrathfd
Copy link
Contributor

@ramseymcgrathfd ramseymcgrathfd commented May 28, 2024 •
edited
Loading

Description

Adding support for providing multiple cluster ips into the bottlerocket template.
This resolves #3050

Motivation and Context

Utilities like node local dns may require multiple cluster-dns-ip values to run properly on bottlerocket. Support in bottle rocket has been available since 1.18 https://github.com/bottlerocket-os/bottlerocket/releases/tag/v1.8.0

Breaking Changes

No

How Has This Been Tested?

  • [ x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • [ x] I have tested and validated these changes using one or more of the provided examples/* projects
  • [ x] I have executed pre-commit run -a on my pull request
  • This has been replicated on existing community-based module in-house

@ramseymcgrathfd ramseymcgrathfd changed the title Support adding additional cluster dns ranges to bottlerocket template feat: Support adding additional cluster dns ranges to bottlerocket template May 28, 2024
@bryantbiggs
Copy link
Member

bryantbiggs commented May 28, 2024 •
edited
Loading

I don't know that we will be accepting this change:

  1. The EKS CoreDNS addon now supports autoscaling so is node local DNS still needed?
  2. I believe you can already pass this value yourself through user data which means we don't have to bake this weird/funky logic into the module:
  bootstrap_extra_args = <<-EOT
      [settings.kubernetes]
      "cluster-dns-ip" = ["172.21.0.10", "169.254.20.10"]
   EOT

@bryantbiggs
Copy link
Member

eh, scratch that. we set the IP here in this module. one sec

@ramseymcgrathfd
Copy link
Contributor Author

ramseymcgrathfd commented May 28, 2024 •
edited
Loading

eh, scratch that. we set the IP here in this module. one sec

yeah its hard-coded to a single ip. Pulling that out completely would also work, users can generate it themselves as an extra arg for the template.
I don't think its a good idea to just assume no one will ever need node-local

@ramseymcgrathfd
Copy link
Contributor Author

Sorry, closed by accident

ramseymcgrathfd
ramseymcgrathfd commented May 28, 2024
View reviewed changes
Copy link
Contributor Author

@ramseymcgrathfd ramseymcgrathfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@bryantbiggs bryantbiggs changed the title feat: Support adding additional cluster dns ranges to bottlerocket template feat: Support additional cluster DNS IPs with Bottlerocket based AMIs May 28, 2024
@bryantbiggs bryantbiggs merged commit 541dbb2 into terraform-aws-modules:master May 28, 2024
@ramseymcgrathfd ramseymcgrathfd deleted the CINF-cluster-dns-generic branch May 28, 2024 18:40
antonbabenko pushed a commit that referenced this pull request May 28, 2024
@semantic-release-bot
chore(release): version 20.12.0 [skip ci]
59024eb 
## [20.12.0](v20.11.1...v20.12.0) (2024-05-28)

### Features

* Support additional cluster DNS IPs with Bottlerocket based AMIs ([#3051](#3051)) ([541dbb2](541dbb2))
@antonbabenko
Copy link
Member

This PR is included in version 20.12.0 🎉

@pcheliniy pcheliniy mentioned this pull request Jun 4, 2024
Closed
3 tasks
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Should be able to configure "cluster-dns-ip"

3 participants

@ramseymcgrathfd @bryantbiggs @antonbabenko
Morty Proxy This is a proxified and sanitized view of the page, visit original site.