Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

wevanscfi
Copy link
Contributor

@wevanscfi wevanscfi commented May 21, 2024

Description

Ignore changes to bootstrap_cluster_creator_admin_permissions to allow upgrading module and importing existing clusters

Motivation and Context

Fixes: #3025

Breaking Changes

None

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

…w upgrading module and importing existing clusters
@igorbrites
Copy link
Contributor

This fix is way simpler than I was anticipating! Thanks @wevanscfi!

main.tf Outdated Show resolved Hide resolved
Co-authored-by: Igor Brites <igor@brites.dev>
@wevanscfi wevanscfi changed the title FIX Issue 3025 fix: Issue 3025 May 21, 2024
main.tf Show resolved Hide resolved
@antlsung
Copy link

❤️

@wevanscfi wevanscfi requested a review from bryantbiggs May 21, 2024 18:22
@bryantbiggs bryantbiggs changed the title fix: Issue 3025 fix: Ignore changes to bootstrap_cluster_creator_admin_permissions which is disabled by default May 21, 2024
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bryantbiggs bryantbiggs merged commit c65d308 into terraform-aws-modules:master May 21, 2024
antonbabenko pushed a commit that referenced this pull request May 21, 2024
## [20.11.1](v20.11.0...v20.11.1) (2024-05-21)

### Bug Fixes

* Ignore changes to `bootstrap_cluster_creator_admin_permissions` which is disabled by default  ([#3042](#3042)) ([c65d308](c65d308))
@antonbabenko
Copy link
Member

This PR is included in version 20.11.1 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terraform tries to recreate clusters previously using ConfigMap auth

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.