Removed unnecessary thread interrupt #722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spikhalskiy
reviewed
Sep 14, 2021
temporal-sdk/src/test/java/io/temporal/worker/CleanWorkerShutdownTest.java
Show resolved
Hide resolved
Spikhalskiy
suggested changes
Sep 14, 2021
Contributor
Spikhalskiy
left a comment
There was a problem hiding this comment.
It looks like this PR cuts off an "interrupted" version of the test instead of fixing anything.
Spikhalskiy
reviewed
Sep 16, 2021
temporal-sdk/src/test/java/io/temporal/worker/CleanWorkerShutdownHeartBeatingActivityTest.java
Show resolved
Hide resolved
Spikhalskiy
reviewed
Sep 16, 2021
| Activity.getExecutionContext().heartbeat("foo"); | ||
| } catch (ActivityWorkerShutdownException e) { | ||
| return "workershutdown"; | ||
| if (now == null) { |
Contributor
There was a problem hiding this comment.
Please move these latches code block up from the try{} catch to improve readability.
I believe CountDownLatch#countDown shouldn't throw an InterruptedException
Contributor
Author
There was a problem hiding this comment.
Moved, but it does not throw the InterruptedException
Spikhalskiy
approved these changes
Sep 16, 2021
sojanmathew
pushed a commit
to sojanmathew/sdk-java
that referenced
this pull request
Oct 19, 2025
Activities that catch InterruptedException, restore the interrupted flag, and continue execution were unable to report their completion due to gRPC call failures. This occurred because gRPC calls fail when the thread's interrupted flag is set. The fix clears the interrupted flag before making gRPC calls in ActivityWorker.sendReply() and restores it afterward, ensuring: - Activity results are successfully reported to the server - Thread interruption semantics are preserved for worker shutdown - All activity completion scenarios work (success/failure/cancellation) Additionally, extract executeGrpcCallWithInterruptHandling() method to eliminate code duplication across the three gRPC response calls, improving maintainability and reducing the risk of inconsistent implementations. Fixes: temporalio#731 Related: temporalio#722
sojanmathew
added a commit
to sojanmathew/sdk-java
that referenced
this pull request
Oct 20, 2025
Activities that catch InterruptedException, restore the interrupted flag, and continue execution were unable to report their completion due to gRPC call failures. This occurred because gRPC calls fail when the thread's interrupted flag is set. The fix clears the interrupted flag before making gRPC calls in ActivityWorker.sendReply() and restores it afterward, ensuring: - Activity results are successfully reported to the server - Thread interruption semantics are preserved for worker shutdown - All activity completion scenarios work (success/failure/cancellation) Additionally, extract executeGrpcCallWithInterruptHandling() method to eliminate code duplication across the three gRPC response calls, improving maintainability and reducing the risk of inconsistent implementations. Fixes: temporalio#731 Related: temporalio#722
sojanmathew
added a commit
to sojanmathew/sdk-java
that referenced
this pull request
Oct 21, 2025
Activities that catch InterruptedException, restore the interrupted flag, and continue execution were unable to report their completion due to gRPC call failures. This occurred because gRPC calls fail when the thread's interrupted flag is set. The fix clears the interrupted flag before making gRPC calls in ActivityWorker.sendReply() and restores it afterward, ensuring: - Activity results are successfully reported to the server - Thread interruption semantics are preserved for worker shutdown - All activity completion scenarios work (success/failure/cancellation) Additionally, extract executeGrpcCallWithInterruptHandling() method to eliminate code duplication across the three gRPC response calls, improving maintainability and reducing the risk of inconsistent implementations. Fixes: temporalio#731 Related: temporalio#722
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Removed unnecessary thread interrupt that prevented the sdk from sending the activity task completed call.
Checklist
Closes CleanWorkerShutdownTest::testShutdownNow[Docker] #721
How was this tested:
Unit test