Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 69d2363

Browse filesBrowse files
SushisourceSushisource
authored
Remove experimental status from worker tuners (#2683)
1 parent 832785d commit 69d2363
Copy full SHA for 69d2363
Expand file treeCollapse file tree

24 files changed

+4
-52
lines changed
Open diff view settings
Collapse file

‎temporal-sdk/src/main/java/io/temporal/worker/MetricsType.java‎

Copy file name to clipboardExpand all lines: temporal-sdk/src/main/java/io/temporal/worker/MetricsType.java
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,6 @@ private MetricsType() {}
125125
public static final String WORKER_TASK_SLOTS_AVAILABLE =
126126
TEMPORAL_METRICS_PREFIX + "worker_task_slots_available";
127127

128-
@Experimental
129128
public static final String WORKER_TASK_SLOTS_USED =
130129
TEMPORAL_METRICS_PREFIX + "worker_task_slots_used";
131130

Collapse file

‎temporal-sdk/src/main/java/io/temporal/worker/WorkerOptions.java‎

Copy file name to clipboardExpand all lines: temporal-sdk/src/main/java/io/temporal/worker/WorkerOptions.java
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,6 @@ public Builder setStickyTaskQueueDrainTimeout(Duration stickyTaskQueueDrainTimeo
417417
* Set a {@link WorkerTuner} to determine how slots will be allocated for different types of
418418
* tasks.
419419
*/
420-
@Experimental
421420
public Builder setWorkerTuner(WorkerTuner workerTuner) {
422421
this.workerTuner = workerTuner;
423422
return this;
Collapse file

‎temporal-sdk/src/main/java/io/temporal/worker/tuning/ActivitySlotInfo.java‎

Copy file name to clipboardExpand all lines: temporal-sdk/src/main/java/io/temporal/worker/tuning/ActivitySlotInfo.java
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
11
package io.temporal.worker.tuning;
22

33
import io.temporal.activity.ActivityInfo;
4-
import io.temporal.common.Experimental;
54
import java.util.Objects;
65

76
/** Contains information about a slot that is being used to execute an activity task. */
8-
@Experimental
97
public class ActivitySlotInfo extends SlotInfo {
108
private final ActivityInfo activityInfo;
119
private final String workerIdentity;
Collapse file

‎temporal-sdk/src/main/java/io/temporal/worker/tuning/CompositeTuner.java‎

Copy file name to clipboardExpand all lines: temporal-sdk/src/main/java/io/temporal/worker/tuning/CompositeTuner.java
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
11
package io.temporal.worker.tuning;
22

3-
import io.temporal.common.Experimental;
43
import java.util.Objects;
54
import javax.annotation.Nonnull;
65

76
/**
87
* Can be used to create a {@link WorkerTuner} which uses specific {@link SlotSupplier}s for each
98
* type of slot.
109
*/
11-
@Experimental
1210
public class CompositeTuner implements WorkerTuner {
1311
private final @Nonnull SlotSupplier<WorkflowSlotInfo> workflowTaskSlotSupplier;
1412
private final @Nonnull SlotSupplier<ActivitySlotInfo> activityTaskSlotSupplier;
Collapse file

‎temporal-sdk/src/main/java/io/temporal/worker/tuning/JVMSystemResourceInfo.java‎

Copy file name to clipboardExpand all lines: temporal-sdk/src/main/java/io/temporal/worker/tuning/JVMSystemResourceInfo.java
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
11
package io.temporal.worker.tuning;
22

33
import com.sun.management.OperatingSystemMXBean;
4-
import io.temporal.common.Experimental;
54
import java.lang.management.ManagementFactory;
65
import java.time.Instant;
76
import java.util.concurrent.locks.Lock;
87
import java.util.concurrent.locks.ReentrantLock;
98

109
/** {@link SystemResourceInfo} implementation that uses JVM-specific APIs to get resource usage. */
11-
@Experimental
1210
public class JVMSystemResourceInfo implements SystemResourceInfo {
1311
// As of relatively recent Java versions (including backports), this class will properly deal with
1412
// containerized environments as well as running on bare metal.
Collapse file

‎temporal-sdk/src/main/java/io/temporal/worker/tuning/LocalActivitySlotInfo.java‎

Copy file name to clipboardExpand all lines: temporal-sdk/src/main/java/io/temporal/worker/tuning/LocalActivitySlotInfo.java
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
11
package io.temporal.worker.tuning;
22

33
import io.temporal.activity.ActivityInfo;
4-
import io.temporal.common.Experimental;
54
import java.util.Objects;
65

76
/** Contains information about a slot that is being used to execute a local activity. */
8-
@Experimental
97
public class LocalActivitySlotInfo extends SlotInfo {
108
private final ActivityInfo activityInfo;
119
private final String workerIdentity;
Collapse file

‎temporal-sdk/src/main/java/io/temporal/worker/tuning/NexusSlotInfo.java‎

Copy file name to clipboardExpand all lines: temporal-sdk/src/main/java/io/temporal/worker/tuning/NexusSlotInfo.java
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
package io.temporal.worker.tuning;
22

3-
import io.temporal.common.Experimental;
43
import java.util.Objects;
54

65
/** Contains information about a slot that is being used to execute a nexus task. */
7-
@Experimental
86
public class NexusSlotInfo extends SlotInfo {
97
private final String service;
108
private final String operation;
Collapse file

‎temporal-sdk/src/main/java/io/temporal/worker/tuning/PollerBehaviorAutoscaling.java‎

Copy file name to clipboardExpand all lines: temporal-sdk/src/main/java/io/temporal/worker/tuning/PollerBehaviorAutoscaling.java
+4-4Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -99,9 +99,9 @@ public int getInitialConcurrentTaskPollers() {
9999
public boolean equals(Object o) {
100100
if (o == null || getClass() != o.getClass()) return false;
101101
PollerBehaviorAutoscaling that = (PollerBehaviorAutoscaling) o;
102-
return minConcurrentTaskPollers == that.minConcurrentTaskPollers
102+
return (minConcurrentTaskPollers == that.minConcurrentTaskPollers
103103
&& maxConcurrentTaskPollers == that.maxConcurrentTaskPollers
104-
&& initialConcurrentTaskPollers == that.initialConcurrentTaskPollers;
104+
&& initialConcurrentTaskPollers == that.initialConcurrentTaskPollers);
105105
}
106106

107107
@Override
@@ -112,13 +112,13 @@ public int hashCode() {
112112

113113
@Override
114114
public String toString() {
115-
return "PollerBehaviorAutoscaling{"
115+
return ("PollerBehaviorAutoscaling{"
116116
+ "minConcurrentTaskPollers="
117117
+ minConcurrentTaskPollers
118118
+ ", maxConcurrentTaskPollers="
119119
+ maxConcurrentTaskPollers
120120
+ ", initialConcurrentTaskPollers="
121121
+ initialConcurrentTaskPollers
122-
+ '}';
122+
+ '}');
123123
}
124124
}
Collapse file

‎temporal-sdk/src/main/java/io/temporal/worker/tuning/PollerBehaviorSimpleMaximum.java‎

Copy file name to clipboardExpand all lines: temporal-sdk/src/main/java/io/temporal/worker/tuning/PollerBehaviorSimpleMaximum.java
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
11
package io.temporal.worker.tuning;
22

3-
import io.temporal.common.Experimental;
43
import java.util.Objects;
54

65
/**
76
* A poller behavior that will attempt to poll as long as a slot is available, up to the provided
87
* maximum. Cannot be less than two for workflow tasks, or one for other tasks.
98
*/
10-
@Experimental
119
public class PollerBehaviorSimpleMaximum implements PollerBehavior {
1210
private final int maxConcurrentTaskPollers;
1311

Collapse file

‎temporal-sdk/src/main/java/io/temporal/worker/tuning/ResourceBasedController.java‎

Copy file name to clipboardExpand all lines: temporal-sdk/src/main/java/io/temporal/worker/tuning/ResourceBasedController.java
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import com.uber.m3.tally.Gauge;
44
import com.uber.m3.tally.Scope;
5-
import io.temporal.common.Experimental;
65
import io.temporal.worker.MetricsType;
76
import java.time.Instant;
87
import java.util.concurrent.atomic.AtomicReference;
@@ -12,7 +11,6 @@
1211
* Is used by {@link ResourceBasedSlotSupplier} and {@link ResourceBasedTuner} to make decisions
1312
* about whether slots should be handed out based on system resource usage.
1413
*/
15-
@Experimental
1614
public class ResourceBasedController {
1715
public final ResourceBasedControllerOptions options;
1816

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.