Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add biometric authentication support in PinInput component#104

Merged
mainsmirnov merged 5 commits intotelegram-mini-apps-dev:maintelegram-mini-apps-dev/TelegramUI:mainfrom
NikGariel:feat-piniput-biometric-buttonNikGariel/TelegramUI:feat-piniput-biometric-buttonCopy head branch name to clipboard
Jul 6, 2025
Merged

Add biometric authentication support in PinInput component#104
mainsmirnov merged 5 commits intotelegram-mini-apps-dev:maintelegram-mini-apps-dev/TelegramUI:mainfrom
NikGariel:feat-piniput-biometric-buttonNikGariel/TelegramUI:feat-piniput-biometric-buttonCopy head branch name to clipboard

Conversation

@NikGariel
Copy link
Copy Markdown
Contributor

Introduce biometric button support with icons for Face ID, Touch ID, and fingerprint detection. Adjust UI styles accordingly and add corresponding handlers for biometric authentication actions.

Introduce biometric button support with icons for Face ID, Touch ID, and fingerprint detection. Adjust UI styles accordingly and add corresponding handlers for biometric authentication actions.
@mainsmirnov
Copy link
Copy Markdown
Collaborator

Thank you for your contribution. Unfortunately, at this time we are unable to review or accept it, as this change must first be reviewed and implemented by the design team. The icon should be built using the special grid, added to the components library in Figma, and the design itself should be implemented in Figma for the PinInput component.

We will revisit this once we have collected sufficient feedback and suggestions for the next major library update

Comment thread src/icons/36/face_id.tsx Outdated
Comment thread src/components/Form/PinInput/hooks/usePinInput.ts Outdated
Comment thread src/components/Form/PinInput/PinInput.tsx Outdated
Comment thread src/components/Form/PinInput/hooks/usePinInput.ts Outdated
Comment thread src/components/Form/PinInput/hooks/usePinInput.ts Outdated
@mainsmirnov
Copy link
Copy Markdown
Collaborator

Nikita reached out and created a Figma fork to showcase his changes. Together with the design team, we refined it slightly and pushed the updates to the main community file. Thank you for your contribution — I’ve left a few minor comments to help improve the code further

NikGariel added 3 commits July 6, 2025 14:11
…uth logic

Ensure consistent `viewBox` attributes across all SVG icons. Optimize biometric authentication PIN handling by introducing `getBiometricComponent` for dynamic icon selection and centralizing pin configuration in `getAvailablePins`. Refactor related code for improved readability and maintainability.
Refactor `PinInput` with a new reusable `getActionButtonComponent` for streamlined handling of backspace and biometric actions. Replace redundant biometric logic with a centralized click handler `onElementClick`. Adjust styles for unified action button icon usage.
Copy link
Copy Markdown
Collaborator

@mainsmirnov mainsmirnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥
Thank you for fixing the comments!

@mainsmirnov mainsmirnov merged commit 99199e0 into telegram-mini-apps-dev:main Jul 6, 2025
@NikGariel NikGariel deleted the feat-piniput-biometric-button branch July 6, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.