Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Merge from upstream#5

Merged
tcwan merged 42 commits intotcwan:mastertcwan/nxt-python:masterfrom
schodet:masterschodet/nxt-python:masterCopy head branch name to clipboard
Jun 13, 2018
Merged

Merge from upstream#5
tcwan merged 42 commits intotcwan:mastertcwan/nxt-python:masterfrom
schodet:masterschodet/nxt-python:masterCopy head branch name to clipboard

Conversation

@tcwan
Copy link
Owner

@tcwan tcwan commented Jun 13, 2018

Pick up fixes from upstream

codestruct and others added 30 commits April 21, 2018 14:58
The loop "for s in find_bricks(host, name, silent, method):" was
indented one level too much so it was only executed when
debug = True. And some more debug print lines.
...and adapt nxtfilemgr accordingly
"Surround top-level function and class definitions with two blank
lines."

https://www.python.org/dev/peps/pep-0008/#blank-lines
Fix nxt_test when --verbose option is NOT given
This fixes the error:

    TypeError: ord() expected string of length 1, but int found

when connecting via Bluetooth

Tested working on Linux.

Closes #124
this tells git to ignore the __pycache__ directory that can be
automatically created by python if you use the nxt module directly
e.g. via PYTHONPATH
Fantom driver support has been removed, so remove all of the remaining
reference to it.
This improves the config file parsing of the method property. It fixes
possible code injection via eval() as well as makes parsing a bit more
robust by filtering out invalid values, such as the obsolete fantom
driver values.

Fixes #137
The port numbers (PORT_* values) are 0-based, however the actual port
numbers printed on the NXT are 1-based. So, add one so that the user
sees the port number printed on the NXT.
Since strings in python3 are UTF-8, calling chr() on an I2C address
>= 0x80 would create an invalid UTF-8 character (0x80 to 0xFF are
illegal). Then later, when encode() was called in add_string(), a
UnicodeEncodeError exception would be thrown because of this.

This adds a new add_bytes() method to the Telegram class for adding
bytes objects. Then, this new method is used in ls_write() so that
we can pass arbitrary I2C addresses without error.
This adds a new class for the official LEGO NXT Temperature sensor.

Fixes #109
Fixes #111
fix off by one in I2C error message
fix TypeError when connecting via Bluetooth
GoldSloth and others added 12 commits April 28, 2018 13:10
Drop remaining references to fantom
add .gitignore to ignore __pycache__
This fixes an exception when there is not config file. The changes from commit cad30b1 introduced this error.
This fixes a TypeError (probably caused by python 2>3 conversion) using the devsock connection on macOS.
Fix TypeError when using devsock connection
fix crash when no config file
bluesock: teach BlueSock init about debug
@tcwan tcwan merged commit da5fa82 into tcwan:master Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.