Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

typings.d.ts: write in ESM format #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pjonsson wants to merge 1 commit into
base: main
Choose a base branch
Loading
from
Open

typings.d.ts: write in ESM format #1061

pjonsson wants to merge 1 commit into from

Conversation

@pjonsson
Copy link

@pjonsson pjonsson commented Mar 19, 2025

Commit 99aa76a indicates that
ESM is used, so write typings.d.ts
in that format too.

Fixes #1059

@pjonsson
typings.d.ts: write in ESM format
c937920 
Commit 99aa76a indicates that
ESM is used, so write typings.d.ts
in that format too.

Fixes taye#1059
@pjonsson
Copy link
Author

pjonsson commented Mar 19, 2025

@taye I believe the CI failure is unrelated to the PR, CI should be fixed with #1062.

@JonathanSamelsonB12
Copy link

JonathanSamelsonB12 commented Apr 2, 2025

Hello,
@athira-inapp thank you for your fix regarding this error! I indeed encountered this when updating my app to Angular 19.
@taye Could those PRs be merged (and released) any time soon? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@pjonsson @JonathanSamelsonB12
Morty Proxy This is a proxified and sanitized view of the page, visit original site.