Add rate limiting for task updates#35
Merged
snopoke merged 4 commits intomaintaskbadger/taskbadger-python:mainfrom Mar 3, 2025
sk/update-intervalstaskbadger/taskbadger-python:sk/update-intervalsCopy head branch name to clipboard
Merged
Add rate limiting for task updates#35snopoke merged 4 commits intomaintaskbadger/taskbadger-python:mainfrom sk/update-intervalstaskbadger/taskbadger-python:sk/update-intervalsCopy head branch name to clipboard
snopoke merged 4 commits intomaintaskbadger/taskbadger-python:mainfrom
sk/update-intervalstaskbadger/taskbadger-python:sk/update-intervalsCopy head branch name to clipboard
Conversation
There was a problem hiding this comment.
PR Overview
This PR adds rate limiting capabilities to task updates by introducing time‐ and value‐based interval checks along with configurable ping intervals to optimize API usage and reduce unnecessary updates.
- Added tests for rate limiting using time and value intervals as well as combined checks.
- Updated the Task API methods (increment_progress, update_progress, ping) to respect new interval parameters.
- Revised test utilities to use full datetime import for consistency.
Reviewed Changes
| File | Description |
|---|---|
| tests/test_sdk.py | Added tests for new rate limiting functionality on task updates. |
| taskbadger/sdk.py | Updated task update methods to include configurable intervals. |
| tests/utils.py | Modified datetime usage to match the new import style. |
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code