added field apiKey to the User bean#99
added field apiKey to the User bean#99alexeyOnGitHub merged 1 commit intotaskadapter:mastertaskadapter/redmine-java-api:masterfrom
Conversation
There was a problem hiding this comment.
that is for parsing JSon strings to User objects only. what about saving users to Redmine server?
There was a problem hiding this comment.
api_key property is read-only, changed value send to server is ignored.
There was a problem hiding this comment.
then we should change the javadoc from
The property is read-only for new users.
to
The value set by this method is ignored by the server. this method is for serialization only.
also, need to mark it as deprecated.
|
need to add a test verifying that API key is not empty or something. or (better yet) - compare it with the API key we used to retrieve the admin user (we know which API key we use). |
|
I'm done with the review for now. |
|
@ciasnmic , can you please add a test for this change? |
added field apiKey to the User bean
mark setApiKey() as deprecated to indicate that it should not be used by the client code.
added ability to read user API access key (based on issue #79)